Fix unused block warnings for template methods #51597
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://bugs.ruby-lang.org/issues/15554 Ruby 3.4 now warns when passing a block to a method that never expects one. In the case of rendered template, a block is always passed for some engines that do expect one, but some never expect it. We can silence that warning by declaring an anonymous block.
casperisfine
force-pushed
the
ruby-head-fixes-2
branch
from
b4882c4
to
6cf883a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/15554
Ruby 3.4 now warns when passing a block to a method that never expects one.
In the case of rendered template, a block is always passed for some engines that do expect one, but some never expect it.
We can silence that warning by declaring an anonymous block.