Fix Mime::Type.parse for HTTP Accept with parameters
#51616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure whether or not this counts as a "minor" bug fix, so current changes have an updated changelog. |
Fixes MIME parsing raising errors on valid parameters rails#51594. Mime type lookups were updated to handle custom registered types as part of rails#48397. This fix the strips out custom media range parameters before falling back to the default type creation.
notchairmk
force-pushed
the
notchairmk/accept-params
branch
from
bc48b38
to
5889b86
Compare
rafaelfranca
added a commit
that referenced
this pull request
Apr 23, 2024
Fix `Mime::Type.parse` for HTTP Accept with parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #51594
This Pull Request has been created because to fix valid Mime::Type parsing of media range parameters.
Detail
This Pull Request changes
Mime::Type.lookup(indirectlyMime::Type.parse) to strip out custom media range parameters before falling back to default type creation. This should fix at least some 406 responses that Rails 7.1 is returning for valid HTTP Accept headers.An example of a failure currently:
Accept: */*;encoding=UTF-8;q=0.9Additional information
It looks like the break was initially introduced in 7.1 from #48397 .
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]