Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter internal frames in deprecation warnings for Ruby 3.4 #51619

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Earlopain
Copy link
Contributor

Motivation / Background

Followup to #50923. On Ruby 3.4 with rails main I get a bunch of deprecation warnings that look like this:

... If automatic inference is not intended, you can silence this warning by defining the association with inverse_of: nil. (called from Array#each at internal:array:54)

Additional information

This test fails for me locally on 3.4 without this change:

Expected "DEPRECATION WARNING: You are using deprecated behavior which will be removed from the next major or minor release. (called from Array#each at internal:array:54)" to not include "internal".

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rafaelfranca rafaelfranca merged commit fa23f0f into rails:main Apr 23, 2024
2 of 3 checks passed
@yahonda
Copy link
Member

yahonda commented Apr 24, 2024

@Earlopain Earlopain deleted the ruby-3.4-backtraces branch April 24, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants