Encourage #lease_connection
over #connection
on AR model #inspect
without connection
#51620
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Ref: #51349
Seeing as
ActiveRecord::Base.connection
is soft deprecated, it's probably worth updating this#inspect
to encourage the use of one of the suggested alternatives instead.Detail
Updates
#inspect
for non-abstract AR model classes to suggest the use of#lease_connection
instead of the soft deprecated#connection
when the model does not have an established connection.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]