Remove reference to builders BlankSlate #51632
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has actually been removed from the builder gem in rails/builder#15 Additionally, `BasicObject` will be more familiar to users.
|
Since ProxyObject is technically a public API , it would have to be deprecated before being removed. But if it's not used anywhere, we should probably just do it. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has actually been removed from the builder gem in rails/builder#15 (currently unreleased). Additionally,
BasicObjectwill be more familiar to users.Should this class be deprecated instead? There are no usages in Rails itself, and no tests. I believe this is a vestige from when Ruby had no
BasicObject.