Update guides: Replace filter with action callback [ci skip] #51645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the updates, I think it makes sense to try to remove the relation to "filter" where possible. (note that we don't need to fully eliminate it, as they are somewhat replaceable)
I had a few small suggestions below, let me know what you think. Also, please make sure to squash any additional commits down to one by the end, before we can consider merging. Thanks again.
notapatch
force-pushed
the
pr-guides-acion-controller-action-callbacks
branch
from
d846dfc
to
b33597a
Compare
|
Agree with all those changes and I've updated the PR per your suggestions. Everything is green/passing and in a single commit! |
Rails 4.2 onwards replaced filter with action callback. However, the term has remained in the rails guides and this PR fixes this. Term used is "action callbacks" as this was used in the changelog: > Deprecate all *_filter callbacks in favor of *_action callbacks. [Original Change](rails@489a8f2) Types of change: - Filter(s) => Action callback(s) - Generalized the word "Action callbacks" as it is longer. - actions => "controller actions" to make "controller actions" more distinct from "action callbacks".
notapatch
force-pushed
the
pr-guides-acion-controller-action-callbacks
branch
from
b33597a
to
66bc210
Compare
I'll be honest Carlos I have "action callback" snow blindness and not a reliable witness. 😆 Tweak done! Everything is green/passing and in a single commit! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Rails 4.2 onwards replaced filter with action callback. However, the term has remained in the rails guides and this PR fixes this.
Term used is "action callbacks" as this was used in the changelog:
Types of change:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]