Fix console_test to make pass after IRB's behavior change #51667
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
In IRB's pull request ruby/irb#907, IRB's behavior with
ENV['TERM']=dumb
will change.After the change, some test in
railties/test/application/console_test.rb
will fail like this.This pull request makes console_test pass.
Detail
write_prompt "123", "prompt> 123"
will executeOutput from IRB will change like this
↓
This pull request changes it to
write_prompt "123", prompt: "prompt> "
which will execute below, and correctly matches in both cases.Additional information
Adding
-- --nomultiline --nosingleline
will emulate IRB's behavior changeTERM=dumb is used in emacs shell. IRB/Reline used to print many redundant test and make it unusable.
The old test was matching to this redundant output part.