Don't mess with Minitest unless RAILS_ENV is set #51718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minitest will automatically scan all installed gems and load plugins from those gems. We should detect whether or not we're being run within the context of a Rails app and only change MT behavior in that case. To determine if we're being run via `bin/rails` we'll just check if RAILS_ENV is set. Ref: minitest/minitest#996 Ref: minitest/minitest#725
justinko
reviewed
May 3, 2024
| @@ -109,6 +109,9 @@ def self.plugin_rails_options(opts, options) | |||
| # Owes great inspiration to test runner trailblazers like RSpec, | |||
| # minitest-reporters, maxitest, and others. | |||
| def self.plugin_rails_init(options) | |||
| # Don't mess with Minitest unless RAILS_ENV is set | |||
| return unless ENV["RAILS_ENV"] | |||
There was a problem hiding this comment.
Excuse my ignorance but would defined?(::Rails) be more accurate?
There was a problem hiding this comment.
Never mind just read the linked issues 🙏
|
@tenderlove I just noticed that running I'm getting around it by just doing Or shall we do nothing and just wait for Minitest to have "explicit plugin loading"? |
|
Does that happen on the application as well? |
|
Great. I fixed on main already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minitest will automatically scan all installed gems and load plugins from those gems. We should detect whether or not we're being run within the context of a Rails app and only change MT behavior in that case.
To determine if we're being run via
bin/railswe'll just check if RAILS_ENV is set.Ref: minitest/minitest#996
Ref: minitest/minitest#725