Reduce allocations in BelongsToAssociation#replace_keys #51754
Merged
+14
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same benchmark as in #51726
replace_keys
always allocate a multiple arrays to support composite primary keys, even though most primary keys likely aren't composite.And even when they are, we can avoid needless allocations by not using
Array#zip
.This reduce allocations by 18% (8k) on that benchmark.
Before:
After:
NB:
belongs_to_association
doesn't show up in top files anymore