Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to DevContainer compose file #51791

Merged

Commits on May 13, 2024

  1. Add name to DevContainer compose file

    Currently when you generate a project the compose.yaml generated
    file does not include the top-level name property. Not having this
    top-level name property makes all containers / volumes started by
    devcontainer to be prepended with the folder name, which is
    `devcontainer` in the case of the .devcontainer/compose.yml` file.
    
    This is ok if you run only one project with devcontainer but starts
    to get problem if you run multiple projects. If you have one project
    that runs on postgresql 15 and a new one that runs on postgresql 16 it
    will fail to boot the postgresql container because both devcontainers is
    using the same volume: `devcontainer_postgres-data`.
    
    This commit fixes this by setting the top-lavel name property with
    the project name, which will make the containers and volumes to be
    prepended with the project name and not with `devcontainer`.
    duduribeiro committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f63d344 View commit details
    Browse the repository at this point in the history