Change asset pipeline default to Propshaft in Rails 8 #51799
Merged
+28
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of tests broken, but once we fix them, we can merge this. main is already Rails 8 |
railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt
Outdated
Show resolved
Hide resolved
MatheusRich
reviewed
May 15, 2024
| @@ -75,7 +75,7 @@ def self.add_shared_options_for(name) | |||
|
|
|||
| class_option :skip_asset_pipeline, type: :boolean, aliases: "-A", default: nil | |||
|
|
|||
| class_option :asset_pipeline, type: :string, aliases: "-a", default: "sprockets", | |||
| class_option :asset_pipeline, type: :string, aliases: "-a", default: "propshaft", | |||
There was a problem hiding this comment.
Might be done in a follow-up PR, but are there documentation changes that we'd like to do as well?
… tests against sprockets too)
|
There's a fair amount of work in switching all the tests that assume sprockets over. If anyone is interested in helping with this transition, I'd love some assistance, while I tune up Propshaft with the other stuff we're missing before a release. |
This was referenced May 20, 2024
|
I'd very much like to help with the transition. I'm not an expert, just an enthusiast. If you think it's something I could help with, I gladly offer my assistance 🚀 |
lazaronixon
reviewed
May 26, 2024
Co-authored-by: Lázaro Nixon <lazaronixon@hotmail.com>
|
Will need to follow up with documentation changes to match the new default. But will do that in a separate PR. |
theodorton
added a commit
to Skalar/shoulda-matchers
that referenced
this pull request
May 27, 2024
Propshaft is default from Rails 8. See rails/rails#51799
theodorton
added a commit
to Skalar/shoulda-matchers
that referenced
this pull request
May 27, 2024
Propshaft is default from Rails 8. See rails/rails#51799
theodorton
added a commit
to Skalar/shoulda-matchers
that referenced
this pull request
May 27, 2024
Propshaft is default from Rails 8. See rails/rails#51799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprockets has served us well, but it's time to hand over the torch to Propshaft in Rails 8.