Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to ci skip in PR title #51809

Closed
wants to merge 1 commit into from

Conversation

Earlopain
Copy link
Contributor

This doesn't do anything anymore, see #51796 (comment)

cc @skipkayhil

@rails-bot rails-bot bot added the docs label May 13, 2024
@skipkayhil
Copy link
Member

skipkayhil commented May 13, 2024

Hmm, I think I misunderstood. It looks like it still skips parts of the buildkite build so its still useful

I'll hold off on merging until I get clarification

@Earlopain
Copy link
Contributor Author

Earlopain commented May 13, 2024

Oh, yeah. I was just surprised that I found it in the checks list here but it looks like it doesn't actually do very much.

I'll hold off on merging until I get clarification

Oops, was a bit too fast. Just reopen if this PR is still relevant

@Earlopain Earlopain closed this May 13, 2024
@zzak
Copy link
Member

zzak commented May 13, 2024

Just for clarity, we had Buildkite toggle the ci skip function off for the Rails org, so we can manually decide which workloads to skip.

For example, we don't want to run the full Rails test suite, but we would like to still generate doc previews.

The definition of that behavior is here:
https://github.com/rails/buildkite-config/blob/847d26b10e6115bea6d05810f62ee50e9387401d/lib/buildkite/config/build_context.rb#L26-L29

And we use it here:
https://github.com/rails/buildkite-config/blob/847d26b10e6115bea6d05810f62ee50e9387401d/pipelines/rails-ci/pipeline.rb#L13-L20

But I'm thinking we probably want to still run the lint group because it can detect bugs in the documentation as well:https://github.com/rails/buildkite-config/blob/847d26b10e6115bea6d05810f62ee50e9387401d/pipelines/rails-ci/pipeline.rb#L169-L183

Any ways, this work was designed to reduce waste on the Rails pipeline to avoid occupying many agents over a doc PR. Now we can selectively run that work while still providing some DX for documentation folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants