Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colspan for representing search results in the rails routes #51874

Merged
merged 1 commit into from
May 24, 2024

Conversation

stiig
Copy link
Contributor

@stiig stiig commented May 21, 2024

Motivation / Background

This Pull Request has been created because after adding a new column Source Location we forget about fixing colspan to fit new columns

Detail

This Pull Request changes displaying of search results

before
image
after (yellow background)
image

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the actionpack label May 21, 2024
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the commits? Thanks.

@rafaelfranca rafaelfranca added this to the 7.2.0 milestone May 24, 2024
@stiig stiig force-pushed the fix-colspan-for-rails-routes branch from d029d23 to 48d7fea Compare May 24, 2024 06:49
@stiig
Copy link
Contributor Author

stiig commented May 24, 2024

@carlosantoniodasilva done

@rafaelfranca rafaelfranca merged commit cff6b2c into rails:main May 24, 2024
3 checks passed
rafaelfranca added a commit that referenced this pull request May 24, 2024
Fix colspan for representing search results in the rails routes
@stiig stiig deleted the fix-colspan-for-rails-routes branch May 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants