Fix tests propshaft #51903
Closed
Fix tests propshaft #51903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazaronixon
force-pushed
the
propshaft-by-default-tests-1
branch
3 times, most recently
from
f45791c
to
6669fc8
Compare
lazaronixon
commented
May 24, 2024
lazaronixon
force-pushed
the
propshaft-by-default-tests-1
branch
4 times, most recently
from
659e702
to
91216d9
Compare
zzak
reviewed
May 24, 2024
| @@ -156,28 +148,10 @@ class User < ActiveRecord::Base; raise 'should not be reached'; end | |||
| assert_no_file_exists("#{app_path}/public/assets/something.else-*.css") | |||
| end | |||
|
|
|||
| test "precompile something.js for directory containing index file" do | |||
There was a problem hiding this comment.
Curious what you're planning to do with the sprockets assets tests
There was a problem hiding this comment.
My idea is to change tests to be compatible with Propshaft and remove those that are not.
There was a problem hiding this comment.
I don't think we should lose the sprockets tests, since we're not deprecating/removing it afaik
lazaronixon
force-pushed
the
propshaft-by-default-tests-1
branch
from
91216d9
to
5ea5d07
Compare
lazaronixon
force-pushed
the
propshaft-by-default-tests-1
branch
2 times, most recently
from
000c241
to
069a1b6
Compare
lazaronixon
force-pushed
the
propshaft-by-default-tests-1
branch
from
069a1b6
to
617a0c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes tests blocking Propshaft from being merged to rails.