Improve ActionCable's TestCookieJar interface #51930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51914
Motivation / Background
This change brings
ActionCable::Connection::TestCookieJar
in alignment withActionDispatch::Cookies::CookieJar
in regards to setting the cookie value.Before:
After:
Additional information
Technically this is a breaking change but I don't know why the user would depend on an incorrect interface.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]