Add an explicit dependency on the logger gem
#52024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzak
reviewed
Jun 5, 2024
This is getting the same treatment as `base64`, `mutex_m`, etc. In Ruby 3.4 it will start to warn: ruby/ruby@d7e558e Remoce require from two files that don't seem to need it
Earlopain
force-pushed
the
explicit-logger-dep
branch
from
139bc6b
to
d9adf17
Compare
carlosantoniodasilva
added a commit
that referenced
this pull request
Jun 5, 2024
Add an explicit dependency on the `logger` gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is getting the same treatment as
base64,mutex_m, etc. In Ruby 3.4 it will start to warn: ruby/ruby@d7e558eSee for example #48907
I also removed two requires that seem unnessesary: The test doesn't access
::Loggerand the other one requiresas/loggerright after.