Skip to content

[#5559] Do not black out the system timezone DST jump hour if Time.zone ... #5571

Merged
merged 1 commit into from May 15, 2012

3 participants

@jarkko
jarkko commented Mar 24, 2012

...differs from that.

The system timezone DST jump hour should not be blacked out by Time.zone.parse if current Time.zone does not do the jump at that time.

Fixes #5559.

@jarkko jarkko [#5559] Do not black out the system timezone DST jump hour if Time.zo…
…ne differs from that.

The system timezone DST jump hour should not be blacked out by Time.zone.parse if current Time.zone does not do the jump at that time.

Fixes #5559.
03becb1
@ahawkins

+1. I can't stand bugs like this. Props @jarkko

@jarkko
jarkko commented Apr 10, 2012

Pinging @tenderlove.

@tenderlove tenderlove merged commit 1c3e5be into rails:master May 15, 2012
@pixeltrix pixeltrix added a commit that referenced this pull request Dec 1, 2012
@pixeltrix pixeltrix Make `Time.zone.parse` to work with JavaScript date strings
Chrome, Safari and Firefox serialize Date objects to strings such
as 'Mon May 28 2012 00:00:00 GMT-0700 (PDT)'. When these strings
are parsed the zone is interpreted as 'GMT-0700' which doesn't
exist in the TzInfo list of timezones.

By taking advantage of the improved date/time handling in 1.9.3
we can use `Date._parse` and the `:offset` value which is parsed
correctly.

Three tests were amended to make them pass:

1.  test_parse_with_old_date

    This needed changing to a different value because the original
    value was before EST was adopted so was being changed to a
    LMT (Local Mean Time) value after the change. It didn't before
    because `DateTime` just has offsets from UTC not timezones.

2.  test_parse_should_not_black_out_system_timezone_dst_jump

    Changed the implementation of this test as the stubs were
    dependent on internal implementation details of the test.
    Confirmed that the modified test still failed when the
    implementation of `parse` was restored to pre-#5571.

3.  test_parse_should_black_out_app_timezone_dst_jump

    Ditto.

Closes #5770.
005d910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.