Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sprockets version to 2.2.0 #5984

Closed

Conversation

guilleiguaran
Copy link
Member

This version fixes encoding issues under Ruby 1.9.

I prefer do a conservative upgrade to 2.2.0 in 3-2-stable branch. In master I upgraded it to 2.4.0

@lucasmazza
Copy link
Contributor

❤️

Also, Sprockets 2.3.1/2.3.2 has some other bugfixes that could be shipped, but bumping to 2.2 is nice enough :)

@jeremy
Copy link
Member

jeremy commented Apr 25, 2012

Safe to bump a dependency like Sprockets on 3-2-stable?

@guilleiguaran
Copy link
Member Author

@jeremy isn't totally safe but some users (like @rafaelfranca) are having those encoding issues.

I would suggest bump it only if we don't have planned any release near and we have enough time to test it to catch any regression.

@rafaelfranca
Copy link
Member

Maybe, relaxing the dependency with something like this will work fine to @lucasmazza case:

s.add_dependency('sprockets',     '>= 2.1.2', '< 2.3.0')

@jeremy
Copy link
Member

jeremy commented Apr 26, 2012

What's unsafe about it?

@rafaelfranca
Copy link
Member

Unsure. Looking at the CHANGELOG and the diff I didn't see nothing that can break.

@kugaevsky
Copy link

Yeah. This dependency upgrade would be very useful.

@clowder
Copy link

clowder commented May 7, 2012

+1

@arunagw
Copy link
Member

arunagw commented May 13, 2012

Hey @guilleiguaran can we close this in favor of #6299 ?

@rafaelfranca
Copy link
Member

I don't think so.

@alanhogan
Copy link

There’s a really annoying bug with glob caching in Sprockets 2.1.3, the version Rails currently requires.

Sprockets is now at 2.4.3.

Can’t we upgrade sprockets?

sstephenson/sprockets#336

@paulcoyle
Copy link

Having the same problems as @alanhogan so consider this a +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants