New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sprockets version to 2.2.0 #5984
Conversation
❤️ Also, Sprockets 2.3.1/2.3.2 has some other bugfixes that could be shipped, but bumping to 2.2 is nice enough :) |
Safe to bump a dependency like Sprockets on 3-2-stable? |
@jeremy isn't totally safe but some users (like @rafaelfranca) are having those encoding issues. I would suggest bump it only if we don't have planned any release near and we have enough time to test it to catch any regression. |
Maybe, relaxing the dependency with something like this will work fine to @lucasmazza case: s.add_dependency('sprockets', '>= 2.1.2', '< 2.3.0') |
What's unsafe about it? |
Yeah. This dependency upgrade would be very useful. |
+1 |
Hey @guilleiguaran can we close this in favor of #6299 ? |
I don't think so. |
There’s a really annoying bug with glob caching in Sprockets 2.1.3, the version Rails currently requires. Sprockets is now at 2.4.3. Can’t we upgrade sprockets? |
Having the same problems as @alanhogan so consider this a +1 |
This version fixes encoding issues under Ruby 1.9.
I prefer do a conservative upgrade to 2.2.0 in 3-2-stable branch. In master I upgraded it to 2.4.0