improve redability #6100
Closed
improve redability #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Class.new for single line class definitions remove some whitespace
| @@ -1,9 +1,7 @@ | |||
| module ActionController | |||
| class ActionControllerError < StandardError #:nodoc: | |||
| end | |||
| ActionControllerError = Class.new StandardError | |||
There was a problem hiding this comment.
Just don't like this syntax, as I think < more clear for understanding that it is inheritance.
There was a problem hiding this comment.
< is syntax sugar for Class.new :)
There was a problem hiding this comment.
I know, so how I said - I don't like Class.new syntax if we can use more readable <:)
There was a problem hiding this comment.
I understand. I just said that < was created for readability IMO :)
|
In general we avoid doing changes throughout Rails source code that are meant just to improve readability. If you are refactoring a part of the code and rewrite it, it is fine, but we ask to avoid sending changes that replace all occurrences of X by Y because it may read better. |
|
Cool, sorry about this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I did some refactoring of single-line class definitions.
Class.newseems more readable than using semicolon, don't you think?Looking forward for your feedback.