remove duplicate usage of Rack::Utils.status_code in LogSubscriber#process_action #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is odd -- any idea why it was wrapped? |
|
This happened here. |
|
I don't know why, I realized it was duplicated, I asked @josevalim the reason behind it, he said it shouldn't be like that, so I sent the pull request. I looked for other cases like that but it was the only one. |
josevalim
added a commit
that referenced
this pull request
May 10, 2012
remove duplicate usage of Rack::Utils.status_code in LogSubscriber#process_action
|
I think it was an accident that happened with the refactoring. Thanks @rafmagana ! |
|
Thank you, @josevalim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.