Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validators docs #6366

Closed
wants to merge 727 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
727 commits
Select commit Hold shift + click to select a range
dfbbf31
Merge pull request #5410 from rafaelfranca/fix-scaffold-3-2
josevalim Mar 13, 2012
21d9c0f
[3-2-stable] Fix GH #5399. connection_pools's keys are ActiveRecord::…
kennyj Mar 13, 2012
5f28145
Fix layout method doc formatting
avakhov Mar 10, 2012
a782fea
Close string quotes
britto Mar 8, 2012
596ecf7
Merge pull request #5417 from kennyj/fix_5399-32
tenderlove Mar 13, 2012
41563b4
ConnectionPool.checkout takes account of ruby using 'non-blocking con…
jrochkind Mar 13, 2012
f2aea24
Merge pull request #5423 from jrochkind/checkout_account_for_monitor_…
tenderlove Mar 14, 2012
16ee611
Do not include the authenticity token in forms where remote: true as …
dhh Mar 14, 2012
e50abba
Allow you to force the authenticity_token to be rendered even on remo…
dhh Mar 14, 2012
ccf4ff0
Remove ActionController::TestCase#rescue_action_in_public!
drogus Mar 15, 2012
9dfb41f
Check for existence of exactly the called `fixture_path=` method
drogus Mar 13, 2012
f918137
Merge pull request #5338 from mreinsch/3-2-static_invalid_byte_sequence
tenderlove Mar 15, 2012
bd3e1ed
Merge pull request #5437 from kennyj/fix_5430
tenderlove Mar 15, 2012
f52ad6c
Merge pull request #5456 from brianmario/redirect-sanitization
tenderlove Mar 15, 2012
e135ff1
Merge pull request #5457 from brianmario/typo-fix
tenderlove Mar 15, 2012
1eb6189
Fix #5440 - multiple render_to_string breaks partials formats
drogus Mar 15, 2012
7130f91
Add missing test for #5308
drogus Mar 15, 2012
e5b46cf
Merge pull request #5480 from drogus/rendering-issues
josevalim Mar 17, 2012
c0a5b85
Ensure load hooks can be called more than once with different contexts.
josevalim Mar 6, 2012
41815f5
Rubyracer does not work on ruby, so add it to Gemfile with :ruby plat…
drogus Mar 17, 2012
f4f9ec1
Fix GH #5435. db:structure:dump should be re-enable.
kennyj Mar 18, 2012
d9355be
Merge pull request #5493 from kennyj/fix_5435-32
drogus Mar 18, 2012
9451201
Build fix for app_generator_test.rb
arunagw Mar 18, 2012
c8fbd48
Merge pull request #5498 from arunagw/build_fix_app_generator_test_3-…
josevalim Mar 18, 2012
74b7829
Increase minimum version of mail.
Mar 19, 2012
fcc8743
Build fix for ruby1.8.7-358
arunagw Mar 19, 2012
358333f
Merge pull request #5505 from arunagw/build_fix_1.8.7-3-2-stable
josevalim Mar 19, 2012
275ee0d
We dont need to merge in the parameters as thats all being reset by t…
dhh Mar 20, 2012
57c6b4c
[3-2-stable] Remove blank line from generated migration
mhfs Mar 21, 2012
565bfb9
migrate(:down) method with table_name_prefix
kennyj Jan 10, 2012
f829515
Merge pull request #5533 from mhfs/migration_blank_line_3_2
josevalim Mar 21, 2012
35bf748
[3-2-stable] Port of #5522 'Fix adding/removing field's index when ge…
mhfs Mar 21, 2012
89f8866
Merge pull request #5542 from mhfs/port_5522_to_32stable
drogus Mar 22, 2012
8c262f7
Fix GH #5411. When precompiling, params method is undefined.
kennyj Mar 20, 2012
b714140
Merge pull request #5525 from kennyj/fix_5411
josevalim Mar 22, 2012
b332891
Add order to tests that rely on db ordering, to fix failing tests on pg
carlosantoniodasilva Mar 22, 2012
ea4e021
Merge pull request #5557 from carlosantoniodasilva/fix-build-3-2
tenderlove Mar 23, 2012
0879ebd
Fix identity map tests
carlosantoniodasilva Mar 23, 2012
ef48cea
Merge pull request #5558 from carlosantoniodasilva/fix-build-3-2
drogus Mar 23, 2012
0382e44
Merge pull request #5537 from kennyj/fix_4399-32
tenderlove Mar 23, 2012
eb0d8ee
chdir before globbing so that we don't need to escape directory names.
tenderlove Mar 23, 2012
907bcce
Return the same session data object when setting session id
carlosantoniodasilva Mar 24, 2012
ed7567c
Fix 'Security#Mass Assignment' URL typo
abevoelker Mar 9, 2012
bd8a970
apply form_for namespace option to date_select
lest Mar 26, 2012
3f1b8c6
Merge pull request #5596 from lest/patch-3
drogus Mar 26, 2012
0e916ae
Merge pull request #5597 from carlosantoniodasilva/fix-build-3-2
josevalim Mar 26, 2012
3eb5be6
Merge pull request #2621 from icco/master
tenderlove Mar 27, 2012
449a4fc
If partial is rendered in controller, grab format from template
drogus Mar 26, 2012
e31ec47
Merge pull request #5603 from drogus/fix-rendered-format-for-render-p…
josevalim Mar 27, 2012
7111133
Fixing issue #2492. ActionView::Base.field_error_proc doesn't call fo…
kryzhovnik Mar 27, 2012
5f37260
Bumping to 3.2.3.rc1
spastorino Mar 27, 2012
fdcfc75
force datetime attributes to be changed
lest Mar 27, 2012
c4048b3
Merge pull request #5618 from lest/patch-1
drogus Mar 27, 2012
a7a422e
Don't break Haml with textarea newline fix.
jcoleman Mar 27, 2012
24208d9
adding a branch to arel
tenderlove Mar 27, 2012
d82e4c8
Merge pull request #5619 from jcoleman/textarea-newline-fix-breaks-haml
spastorino Mar 27, 2012
4f66586
Merge pull request #5619 from jcoleman/textarea-newline-fix-breaks-haml
spastorino Mar 27, 2012
6968bc1
Check if the options hash already exists and merge it with the another
rafaelfranca Mar 27, 2012
460d2c7
Merge pull request #5622 from rafaelfranca/fix-2492-3-2
jeremy Mar 27, 2012
79c8def
Add arel branch to the tests
rafaelfranca Mar 27, 2012
f8b4ef1
Merge pull request #5624 from rafaelfranca/fix-build
NZKoz Mar 28, 2012
2d5b60e
Merge pull request #5616 from cbartlett/migration-indent
spastorino Mar 28, 2012
d646d9d
Added config.action_view.embed_authenticity_token_in_remote_forms
drogus Mar 28, 2012
0d052c0
Merge pull request #5633 from drogus/embed-auth-token-in-remote-forms
spastorino Mar 28, 2012
84ca8c8
Merge pull request #5633 from drogus/embed-auth-token-in-remote-forms
spastorino Mar 28, 2012
4c44ca5
Test for #5549.
tenderlove Mar 27, 2012
1b9fd79
Fix #5549.
jonleighton Mar 28, 2012
d5980b5
Cover one more case in auth_token and remote forms
drogus Mar 28, 2012
db2c135
Cover one more case in auth_token and remote forms
drogus Mar 28, 2012
ef3f809
Change the order argument from ('id') to ('taggings.id')
yahonda Mar 28, 2012
f369f77
Merge pull request #5640 from yahonda/address_ora_00918_with_oracle
spastorino Mar 28, 2012
5747e53
Set proper rendered_format when doing render :inline
spastorino Mar 28, 2012
87825a6
Set proper rendered_format when doing render :inline
spastorino Mar 28, 2012
a157d59
Changed the config.assets.manifest to nil in the comments in the prod…
andhapp Mar 28, 2012
2b2a760
Merge pull request #5644 from andhapp/fix-config-asset-manifest-3-2
spastorino Mar 29, 2012
1d753ab
fix incorrect url in the deprecation message for vendor/plugins [ci s…
vijaydev Mar 29, 2012
921c404
fix incorrect url in the deprecation message for vendor/plugins [ci s…
vijaydev Mar 29, 2012
dd69076
Add missing CHANGELOG entry
spastorino Mar 29, 2012
b395ca1
Add missing CHANGELOG entry
spastorino Mar 29, 2012
5284e65
Bumping to 3.2.3.rc2
spastorino Mar 29, 2012
b29e868
Adds a test that breaks IM when using #select
arturopie Mar 26, 2012
2c8f84d
Do not add record to identity map if the record doesn't have values f…
arturopie Mar 26, 2012
714a2c8
refactor the checking of the attributes of the record in IdentityMap#…
arturopie Mar 27, 2012
6896cd4
refactor instantiate method in base, so we remove nesting if's which …
arturopie Mar 27, 2012
13fe190
Remove the leading \n added by textarea on assert_select
spastorino Mar 30, 2012
5c7bb86
Remove the leading \n added by textarea on assert_select
spastorino Mar 30, 2012
dffbb52
Fix #5667. Preloading should ignore scoping.
jonleighton Mar 30, 2012
45d6cd9
Bump up to 3.2.3
spastorino Mar 30, 2012
69465d9
Merge branch '3-2-3' into 3-2-stable
spastorino Mar 30, 2012
9894d16
Merge pull request #5662 from arturopie/3-2_fixing_IM_when_using_find…
tenderlove Mar 30, 2012
27fc6ec
Fix the redirect when it receive blocks with arity of 1.
rafaelfranca Mar 31, 2012
515e1d3
Usage file in generators shouldn't be fetched only based on source_root
drogus Mar 31, 2012
8e315b0
DATABASE_URL allows omission of database.yml
tpope Apr 3, 2012
6f19262
Remove unused 'cast_code' variable
kevmoo Apr 3, 2012
93f25ac
test initializer logic for DATABASE_URL env var
hone Apr 4, 2012
d46ad34
log which config format AR uses to connect with
hone Apr 4, 2012
c4d3102
Merge pull request #5727 from hone/ar_database_url_logging
tenderlove Apr 4, 2012
6663dd0
Merge pull request #5188 from jlxw/patch-1
spastorino Apr 4, 2012
1124ac0
Fix tests of benchmark with silence equals to true
rafaelfranca Apr 4, 2012
56d9945
Merge pull request #5737 from rafaelfranca/3-2-stable
spastorino Apr 4, 2012
1cd939a
Fix Rails version in getting started guide.
anildigital Apr 6, 2012
bfd5c84
Merge pull request #5765 from anildigital/3-2-stable
vijaydev Apr 6, 2012
05d4ccf
Fix 'Everyday Git' link
anildigital Apr 6, 2012
5c7bcfc
default_url_options does not receive one argument anymore
rafaelfranca Apr 9, 2012
6f4f499
Document that default_url_options must return a hash with symbolized
rafaelfranca Apr 9, 2012
e7671b5
Merge pull request #5784 from rafaelfranca/default_url-3-2
spastorino Apr 9, 2012
b125db8
rewords the section about default_url_options in the Action Controlle…
fxn Apr 9, 2012
dab76b1
Merge pull request #5725 from kevmoo/remove_unused_castcode
fxn Apr 9, 2012
b1c28d7
README fix! [skip ci]
arunagw Apr 10, 2012
a85ffd0
Merge pull request #5799 from arunagw/readme_fix
vijaydev Apr 10, 2012
ca0c0a2
add the class name to the assertion message
tenderlove Jan 5, 2012
2991370
bigdecimal can be duped on Ruby 2.0
tenderlove Mar 20, 2012
fedd87c
probably should require the objects we monkey patch.
tenderlove Mar 20, 2012
e0fd4fc
Merge pull request #5800 from arunagw/bigdecimal_dup
jeremy Apr 10, 2012
96d81e5
test against ruby features in order to fix tests on Ruby 2.0
tenderlove Mar 26, 2012
e473e1f
Merge pull request #5820 from arunagw/more_ruby-2-0-fixes
jeremy Apr 12, 2012
c0e6a85
Fix code example in generator test case
sikachu Apr 9, 2012
efa9a1f
fix typo in readme [ci skip]
vijaydev Apr 12, 2012
2f9fdbf
"rails new -h" shows message in rails directory
alekseykulikov Apr 9, 2012
a748eca
Add missing require in Active Support time zones (fixes #5854)
drogus Apr 15, 2012
9b14e3f
multi_json is restricted to < 1.3
arunagw Apr 16, 2012
9a97699
Merge pull request #5861 from arunagw/multi_json_fix_3-2-stable
jeremy Apr 16, 2012
dcc11b2
catch nil.to_sym errors in partial_renderer, and raise ArgumentError …
Apr 16, 2012
6b8dd70
converting some tests to assert_raises, and DRY'ing retrieve_variable…
Apr 16, 2012
56674db
Replace ruby-debug19 which doesnt work on 1.9.3 out of the box with a…
Apr 17, 2012
89f99e8
Merge pull request #5874 from asanghi/3-2-stable
jeremy Apr 17, 2012
d92166c
Check for nil logger
norman Apr 18, 2012
476fa7a
Merge pull request #5894 from norman/3-2-fix-nil-logger
tenderlove Apr 18, 2012
3986139
Add hook for add_resource_route
spastorino Apr 17, 2012
1166d49
Revert "Fix #5667. Preloading should ignore scoping."
jeremy Apr 19, 2012
e01bf0a
Revert "multi_json is restricted to < 1.3 "
sferik Apr 19, 2012
5e62670
Use `Object#respond_to?` to determine which MultiJson API to use
sferik Apr 19, 2012
13f1401
Removes caching from ActiveRecord::Core::ClassMethods#relation
benedikt Apr 3, 2012
8491740
Adds test to check that circular preloading does not modify Model.uns…
benedikt Apr 3, 2012
2c21a2f
Revert "Revert "Fix #5667. Preloading should ignore scoping.""
benedikt Apr 19, 2012
ebfa58a
Removes unneeded caching from ActiveRecord::Base.relation
benedikt Apr 19, 2012
b9e5c5a
Merge pull request #5898 from benedikt/3-2-stable
jeremy Apr 19, 2012
f51557d
Be sure to correctly fetch PK name from MySQL even if the PK has some…
amatsuda Apr 19, 2012
07b1fe5
Only include Rake::DSL if it's defined.
Apr 21, 2012
c3d50b3
Merge pull request #5896 from sferik/revert_5861
jeremy Apr 21, 2012
210713e
ARes URL should be pointed to 3-2-stable tree not master.
arunagw Apr 23, 2012
0ed6e13
Merge pull request #5935 from arunagw/readme_fixes_3-2-stable
vijaydev Apr 23, 2012
21b1a79
Updated other README to point 3-2-stable
arunagw Apr 23, 2012
979e9d0
Merge pull request #5936 from arunagw/other_readme_fixes
vijaydev Apr 23, 2012
dd01c11
Merge pull request #5919 from joevandyk/rake-dsl-fix
jeremy Apr 23, 2012
0f5af60
Merge pull request #5866 from tiegz/minor_fixes_3-2-stable
tenderlove Apr 23, 2012
0f3fd78
Fix broken test from the earlier merge conflict
sikachu Apr 23, 2012
db6787a
Merge pull request #5946 from sikachu/3-2-stable-fix-merge-conflict
spastorino Apr 23, 2012
d95f3d3
Fix build. It seems that the Mocha's behavior were changed.
kennyj Apr 24, 2012
9212083
Merge pull request #5968 from sikachu/3-2-stable-backport
jeremy Apr 24, 2012
20f398d
Add extra order clause to fix failing test on Ruby 1.8.7
carlosantoniodasilva Apr 24, 2012
7d95b81
Merge pull request #5971 from carlosantoniodasilva/fix-build-3-2
jeremy Apr 25, 2012
006de25
fix number_to_human docs [ci skip]
vijaydev Apr 26, 2012
05bee99
Merge pull request #4528 from j-manu/log-tailer-fix
tenderlove Jan 20, 2012
7006e97
Do not mutate options hash
carlosantoniodasilva Jan 18, 2012
434be0f
Merge pull request #6022 from sikachu/3-2-stable-record_tag_backport
tenderlove Apr 27, 2012
61d84e0
Remove circular require of time/zones
oscardelben Apr 21, 2012
86559be
Merge pull request #6038 from arunagw/warning_removed_3-2-stable
drogus Apr 28, 2012
7dc83f7
Allow Thor 0.15 and 1.0, to be released shortly
Apr 28, 2012
beba826
Lazy load `default_form_builder` if it's passed as a string
drogus Apr 29, 2012
d6bbd33
Don't convert params if the request isn't HTML - fixes #5341
pixeltrix Apr 29, 2012
a782aa5
Fix the build.
rafaelfranca Apr 29, 2012
b18603b
Remove warning of unused variable
rafaelfranca Apr 29, 2012
0df261a
Merge pull request #6051 from rafaelfranca/fix_build
josevalim Apr 29, 2012
b608cdd
Escape interpolated params when redirecting - fixes #5688
pixeltrix Apr 29, 2012
4075a39
Add missing require from b608cdd64c95d0d16eb98d86562e22f3b01be9e3
pixeltrix Apr 29, 2012
6cad407
Restore interpolation of path option in redirect routes
pixeltrix Apr 29, 2012
6b8a3a0
Add missing require when helpers are used in isolation
rafaelfranca Apr 21, 2012
9dc57fe
Deprecate link_to_function and button_to_function helpers
rafaelfranca Apr 21, 2012
342b54a
Add CHANGELOG entry.
rafaelfranca Apr 21, 2012
3005f58
Add release data to Rails 3.2.3
rafaelfranca Apr 21, 2012
8fec5d7
Merge pull request #5922 from rafaelfranca/deprecate_javascript_helpers
jeremy Apr 30, 2012
a72fe84
Add note about using 303 See Other for XHR requests other than GET/POST
pixeltrix Apr 30, 2012
e3069c6
fix the Flash middleware loading the session on every request (very d…
willbryant Jan 23, 2012
2b2983d
Failing test for #6034
drogus Apr 30, 2012
5fe88b1
Correcting some confusion. Pago Pago is part of American Samoa, not S…
IamNaN Apr 13, 2012
df84577
Fix #3993 assets:precompile task does not detect index files
route Apr 30, 2012
580e767
Added test for assets:precompile for index files
route May 1, 2012
02ca915
Deprecate remove_column with array as an argument
drogus May 1, 2012
ebe994f
Merge pull request #6095 from route/assets_precompile_task
jeremy May 2, 2012
4657dba
Fix #4979 against 3-2-stable - delete_all raise an error if a limit i…
May 2, 2012
7c7fb3a
Reset the request parameters after a constraints check
pixeltrix May 2, 2012
0621ecb
Make sure that javascript_include_tag/stylesheet_link_tag methods in
jmbejar May 3, 2012
bfb25f9
Add a role option to wrap_parameters.
nragaz Jan 13, 2012
b4ae94f
improvements in "caching_with_rails" guide - backported from docrails
Mar 22, 2012
5384bdb
Merge pull request #6158 from Dagnan/3-2-stable
vijaydev May 4, 2012
145cc69
added beginning_of_hour support to core_ext calculations for Time and…
mjtko May 4, 2012
efb054b
Merge pull request #4445 from nragaz/role_based_params_wrapping
josevalim May 4, 2012
80a292c
Merge pull request #6128 from frodsan/delete_all_limit_32
tenderlove May 5, 2012
915879c
Give more detailed instructions in script/rails in engine
drogus May 5, 2012
7fb268d
Merge pull request #6170 from mjtko/feature-beginning_of_hour-for-3-2…
jeremy May 5, 2012
6f38348
Add failing test re #3436 which demonstrates content_type is not resp…
kshahkshah May 7, 2012
4d52738
If content_type is explicitly passed to the :head method use the valu…
kshahkshah May 7, 2012
b86e0be
Merge pull request #6198 from whistlerbrk/3-2-stable
josevalim May 8, 2012
764e2de
locking ruby-prof until we got a fix
arunagw May 8, 2012
b12d03d
Merge pull request #6200 from arunagw/3-2-stable
spastorino May 8, 2012
96fe0af
added docs to attribute_accessors methods
May 8, 2012
ad4d408
Merge pull request #6211 from frodsan/docs_attr_accessor_32stable
vijaydev May 8, 2012
16a9a87
removing docs duplication
May 8, 2012
5059c32
Merge pull request #6213 from frodsan/cut_docs_dup
vijaydev May 8, 2012
ba48e23
Fix build
May 9, 2012
dd7e7b3
fix attribute_accessors docs to support 1.8 syntax
May 9, 2012
cb242a9
Merge pull request #6218 from frodsan/fix_docs_32stable
vijaydev May 9, 2012
fa34ace
Stop showing deprecations for Ruby 1.8.7 with remove_column
carlosantoniodasilva May 9, 2012
381f6e7
Merge pull request #6223 from carlosantoniodasilva/remove-columns-dep…
pixeltrix May 9, 2012
705a70f
Bring activesupport CHANGELOG up-to-date/consistent with master.
mjtko May 9, 2012
9b777d5
Add CHANGELOG section for unreleased Rails 3.2.4; document addition o…
mjtko May 9, 2012
b003ddf
Merge pull request #6228 from mjtko/changelog-fixes-for-3-2-stable
vijaydev May 9, 2012
8f5079f
Merge pull request #6219 from frodsan/fix_build
drogus May 9, 2012
f8dae86
Merge pull request #6149 from jmbejar/javascript_include_tag_with_not…
spastorino May 9, 2012
f02e7dc
Deprecate ::instantiate_fixtures unused parameter
alexeymuranov May 9, 2012
9810555
Remove deprecated use of ::instantiate_fixtures
alexeymuranov May 9, 2012
22a6072
Merge pull request #6221 from alexeymuranov/deprecate__instantiate_fi…
jeremy May 10, 2012
c2193c1
Make sure TimeoutError is loaded.
spectator May 9, 2012
a9fc8a9
Merge pull request #6230 from spectator/active_resource_exceptions
jeremy May 10, 2012
f3aaac4
Refactor the handling of default_url_options in integration tests
pixeltrix May 10, 2012
66e338a
Don't ignore nil positional arguments for url helpers - fixes #6196.
pixeltrix May 10, 2012
62f098d
Return false for exists? with new records - fixes #6199.
pixeltrix May 10, 2012
9d616ea
Update performance profiler to work with latest ruby-prof
arunagw May 11, 2012
4b59961
Ruby-Prof works with ruby-1.9.3 also.
arunagw May 11, 2012
5ecd14c
Remove unused private method yaml_fixtures_key
alexeymuranov May 11, 2012
9cead4a
Merge pull request #6262 from arunagw/ruby_prof_fix
spastorino May 11, 2012
ccf80c2
Update 'getting started' guides for new whitelist security implementa…
May 12, 2012
41e7a2a
Merge pull request #6292 from erichmenge/3-2-stable-docfix
rafaelfranca May 12, 2012
2f4696d
adding examples and docs
May 13, 2012
3d0e7ad
Merge pull request #6294 from frodsan/docs_backport
vijaydev May 13, 2012
62b74b1
Upgrade sprockets to 2.1.3
guilleiguaran May 13, 2012
3f7ed52
:foreign_key option should be on has_many side of association
mikdiet Mar 23, 2012
8a5b51e
Merge pull request #6299 from guilleiguaran/upgrade-sprockets-3-2-stable
spastorino May 13, 2012
e7d5ba3
Merge pull request #6306 from erichmenge/3-2-stable-guide-fix
carlosantoniodasilva May 13, 2012
9ff97b0
Merge pull request #3237 from sakuro/data-url-scheme
rafaelfranca May 13, 2012
1aff772
Deprecate `:mouseover` options for `image_tag` helper.
rafaelfranca May 13, 2012
9199ddf
Merge pull request #6266 from alexeymuranov/remove_unused_private_method
carlosantoniodasilva May 14, 2012
4588684
Update railties/lib/rails/generators/rails/app/templates/config/appli…
homakov May 12, 2012
ec68258
Default escape_html_entities_in_json to true in new apps
josevalim May 14, 2012
2506d4a
Merge pull request #6018 from lest/patch-1
carlosantoniodasilva May 14, 2012
21141e7
Deprecate `:disable_with` in favor of `'data-disable-with'` option fo…
May 14, 2012
d47d6e7
Fix typo
May 14, 2012
e9051e2
Deprecate `:disable_with` for `button_tag` too
May 14, 2012
b2f73c4
Backporting some docs on core_ext/hash
May 15, 2012
007539d
Merge pull request #6321 from frodsan/backport_docs
vijaydev May 15, 2012
396e383
clean the errors if an object that includes validations errors is dup…
acapilleri May 15, 2012
9a868a0
Merge pull request #6324 from acapilleri/dup_validation_3_2
rafaelfranca May 15, 2012
2dfa8b5
Fix indent from previous merge
carlosantoniodasilva May 15, 2012
e885b18
add backport for the pull request #6324
May 15, 2012
8470fdb
Merge pull request #6329 from acapilleri/backport_dup_validation_3_2
rafaelfranca May 15, 2012
9f4c4f6
Changing the indentation level of the block comment close for SASS
bcardarella May 16, 2012
e3033e3
Merge pull request #6340 from bcardarella/patch-3
tenderlove May 16, 2012
0f43592
Fix CollectionAssociation#replace to return new target (closes #6231)
drogus May 10, 2012
4bbd05c
fix validations docs
May 17, 2012
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions Gemfile
Expand Up @@ -14,7 +14,7 @@ gem 'jquery-rails'
if ENV['JOURNEY']
gem 'journey', :path => ENV['JOURNEY']
else
gem 'journey'
gem 'journey', :git => 'git://github.com/rails/journey.git', :branch => '1-0-stable'
end

# This needs to be with require false to avoid
Expand Down Expand Up @@ -47,7 +47,7 @@ instance_eval File.read '.Gemfile' if File.exists? '.Gemfile'

platforms :mri do
group :test do
gem 'ruby-prof' if RUBY_VERSION < '1.9.3'
gem 'ruby-prof', '~> 0.11.2'
end
end

Expand Down
2 changes: 1 addition & 1 deletion RAILS_VERSION
@@ -1 +1 @@
3.2.0.rc1
3.2.3
2 changes: 1 addition & 1 deletion Rakefile
Expand Up @@ -94,7 +94,7 @@ RDoc::Task.new do |rdoc|

rdoc.options << '-f' << 'sdoc'
rdoc.options << '-T' << 'rails'
rdoc.options << '-c' << 'utf-8'
rdoc.options << '-e' << 'UTF-8'
rdoc.options << '-g' # SDoc flag, link methods to GitHub
rdoc.options << '-m' << RDOC_MAIN

Expand Down
25 changes: 24 additions & 1 deletion actionmailer/CHANGELOG.md
@@ -1,3 +1,25 @@
## Rails 3.2.3 (March 30, 2012) ##

* Upgrade mail version to 2.4.3 *ML*


## Rails 3.2.2 (March 1, 2012) ##

* No changes.


## Rails 3.2.1 (January 26, 2012) ##

* No changes.


## Rails 3.2.0 (January 20, 2012) ##

* Upgrade mail version to 2.4.0 *ML*

* Remove Old ActionMailer API *Josh Kalderimis*


## Rails 3.1.0 (August 30, 2011) ##

* No changes
Expand All @@ -8,7 +30,7 @@
* remove AM delegating register_observer and register_interceptor to Mail *Josh Kalderimis*


* Rails 3.0.6 (April 5, 2011)
## Rails 3.0.6 (April 5, 2011) ##

* Don't allow i18n to change the minor version, version now set to ~> 0.5.0 *Santiago Pastorino*

Expand Down Expand Up @@ -76,6 +98,7 @@
* Mail does not have "quoted_body", "quoted_subject" etc. All of these are accessed via body.encoded, subject.encoded etc

* Every object in a Mail object returns an object, never a string. So Mail.body returns a Mail::Body class object, need to call #encoded or #decoded to get the string you want.

* Mail::Message#set_content_type does not exist, it is simply Mail::Message#content_type

* Every mail message gets a unique message_id unless you specify one, had to change all the tests that check for equality with expected.encoded == actual.encoded to first replace their message_ids with control values
Expand Down
2 changes: 1 addition & 1 deletion actionmailer/README.rdoc
Expand Up @@ -143,7 +143,7 @@ The latest version of Action Mailer can be installed with RubyGems:

Source code can be downloaded as part of the Rails project on GitHub

* https://github.com/rails/rails/tree/master/actionmailer
* https://github.com/rails/rails/tree/3-2-stable/actionmailer


== License
Expand Down
2 changes: 1 addition & 1 deletion actionmailer/actionmailer.gemspec
Expand Up @@ -17,5 +17,5 @@ Gem::Specification.new do |s|
s.requirements << 'none'

s.add_dependency('actionpack', version)
s.add_dependency('mail', '~> 2.3.0')
s.add_dependency('mail', '~> 2.4.4')
end
3 changes: 2 additions & 1 deletion actionmailer/lib/action_mailer/base.rb
Expand Up @@ -5,6 +5,7 @@
require 'active_support/core_ext/proc'
require 'active_support/core_ext/string/inflections'
require 'active_support/core_ext/hash/except'
require 'active_support/core_ext/module/anonymous'
require 'action_mailer/log_subscriber'

module ActionMailer #:nodoc:
Expand Down Expand Up @@ -375,7 +376,7 @@ def register_interceptor(interceptor)
end

def mailer_name
@mailer_name ||= name.underscore
@mailer_name ||= anonymous? ? "anonymous" : name.underscore
end
attr_writer :mailer_name
alias :controller_path :mailer_name
Expand Down
4 changes: 2 additions & 2 deletions actionmailer/lib/action_mailer/collector.rb
Expand Up @@ -22,9 +22,9 @@ def any(*args, &block)

def custom(mime, options={})
options.reverse_merge!(:content_type => mime.to_s)
@context.freeze_formats([mime.to_sym])
@context.formats = [mime.to_sym]
options[:body] = block_given? ? yield : @default_render.call
@responses << options
end
end
end
end
4 changes: 2 additions & 2 deletions actionmailer/lib/action_mailer/version.rb
Expand Up @@ -2,8 +2,8 @@ module ActionMailer
module VERSION #:nodoc:
MAJOR = 3
MINOR = 2
TINY = 0
PRE = "rc1"
TINY = 3
PRE = nil

STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
end
Expand Down
13 changes: 13 additions & 0 deletions actionmailer/test/base_test.rb
Expand Up @@ -562,6 +562,19 @@ def notify
assert_equal ["notify"], FooMailer.action_methods
end

test "mailer can be anonymous" do
mailer = Class.new(ActionMailer::Base) do
def welcome
mail
end
end

assert_equal "anonymous", mailer.mailer_name

assert_equal "Welcome", mailer.welcome.subject
assert_equal "Anonymous mailer body", mailer.welcome.body.encoded.strip
end

protected

# Execute the block setting the given values and restoring old values after
Expand Down
1 change: 1 addition & 0 deletions actionmailer/test/fixtures/anonymous/welcome.erb
@@ -0,0 +1 @@
Anonymous mailer body
98 changes: 96 additions & 2 deletions actionpack/CHANGELOG.md
@@ -1,4 +1,98 @@
## Rails 3.2.0 (unreleased) ##
## Rails 3.2.4 (unreleased) ##

* Deprecate `:disable_with` in favor of `'data-disable-with'` option for `button_to`, `button_tag` and `submit_tag` helpers.

*Carlos Galdino + Rafael Mendonça França*

* Deprecate `:mouseover` option for `image_tag` helper. *Rafael Mendonça França*

* Deprecate `button_to_function` and `link_to_function` helpers. *Rafael Mendonça França*


## Rails 3.2.3 (March 30, 2012) ##

* Allow to lazy load `default_form_builder` by passing a `String` instead of a constant. *Piotr Sarnacki*

* Fix #5632, render :inline set the proper rendered format. *Santiago Pastorino*

* Fix textarea rendering when using plugins like HAML. Such plugins encode the first newline character in the content. This issue was introduced in https://github.com/rails/rails/pull/5191 *James Coleman*

* Remove the leading \n added by textarea on assert_select. *Santiago Pastorino*

* Add `config.action_view.embed_authenticity_token_in_remote_forms` (defaults to true) which allows to set if authenticity token will be included by default in remote forms. If you change it to false, you can still force authenticity token by passing `:authenticity_token => true` in form options *Piotr Sarnacki*

* Do not include the authenticity token in forms where remote: true as ajax forms use the meta-tag value *DHH*

* Turn off verbose mode of rack-cache, we still have X-Rack-Cache to
check that info. Closes #5245. *Santiago Pastorino*

* Fix #5238, rendered_format is not set when template is not rendered. *Piotr Sarnacki*

* Upgrade rack-cache to 1.2. *José Valim*

* ActionController::SessionManagement is deprecated. *Santiago Pastorino*

* Since the router holds references to many parts of the system like engines, controllers and the application itself, inspecting the route set can actually be really slow, therefore we default alias inspect to to_s. *José Valim*

* Add a new line after the textarea opening tag. Closes #393 *Rafael Mendonça França*

* Always pass a respond block from to responder. We should let the responder to decide what to do with the given overridden response block, and not short circuit it. *sikachu*

* Fixes layout rendering regression from 3.2.2. *José Valim*


## Rails 3.2.2 (March 1, 2012) ##

* Format lookup for partials is derived from the format in which the template is being rendered. Closes #5025 part 2 *Santiago Pastorino*

* Use the right format when a partial is missing. Closes #5025. *Santiago Pastorino*

* Default responder will now always use your overridden block in `respond_with` to render your response. *Prem Sichanugrist*

* check_box helper with :disabled => true will generate a disabled hidden field to conform with the HTML convention where disabled fields are not submitted with the form.
This is a behavior change, previously the hidden tag had a value of the disabled checkbox.
*Tadas Tamosauskas*


## Rails 3.2.1 (January 26, 2012) ##

* Documentation improvements.

* Allow `form.select` to accept ranges (regression). *Jeremy Walker*

* `datetime_select` works with -/+ infinity dates. *Joe Van Dyk*


## Rails 3.2.0 (January 20, 2012) ##

* Setting config.assets.logger to false turn off Sprockets logger *Guillermo Iguaran*

* Add `config.action_dispatch.default_charset` to configure default charset for ActionDispatch::Response. *Carlos Antonio da Silva*

* Deprecate setting default charset at controller level, use the new `config.action_dispatch.default_charset` instead. *Carlos Antonio da Silva*

* Deprecate ActionController::UnknownAction in favour of AbstractController::ActionNotFound. *Carlos Antonio da Silva*

* Deprecate ActionController::DoubleRenderError in favour of AbstractController::DoubleRenderError. *Carlos Antonio da Silva*

* Deprecate method_missing handling for not found actions, use action_missing instead. *Carlos Antonio da Silva*

* Deprecate ActionController#rescue_action, ActionController#initialize_template_class, and ActionController#assign_shortcuts.
These methods were not being used internally anymore and are going to be removed in Rails 4. *Carlos Antonio da Silva*

* Add config.assets.logger to configure Sprockets logger *Rafael França*

* Use a BodyProxy instead of including a Module that responds to
close. Closes #4441 if Active Record is disabled assets are delivered
correctly *Santiago Pastorino*

* Rails initialization with initialize_on_precompile = false should set assets_dir *Santiago Pastorino*

* Add font_path helper method *Santiago Pastorino*

* Depends on rack ~> 1.4.0 *Santiago Pastorino*

* Add :gzip option to `caches_page`. The default option can be configured globally using `page_cache_compression` *Andrey Sitnik*

* The ShowExceptions middleware now accepts a exceptions application that is responsible to render an exception when the application fails. The application is invoked with a copy of the exception in `env["action_dispatch.exception"]` and with the PATH_INFO rewritten to the status code. *José Valim*

Expand All @@ -12,7 +106,7 @@
<%= f.button %>
<% end %>

* Date helpers accept a new option, `:use_two_digit_numbers = true`, that renders select boxes for months and days with a leading zero without changing the respective values.
* Date helpers accept a new option, `:use_two_digit_numbers = true`, that renders select boxes for months and days with a leading zero without changing the respective values.
For example, this is useful for displaying ISO8601-style dates such as '2011-08-01'. *Lennart Fridén and Kim Persson*

* Make ActiveSupport::Benchmarkable a default module for ActionController::Base, so the #benchmark method is once again available in the controller context like it used to be *DHH*
Expand Down
4 changes: 2 additions & 2 deletions actionpack/README.rdoc
Expand Up @@ -218,7 +218,7 @@ A short rundown of some of the major features:

def show
# the output of the method will be cached as
# ActionController::Base.page_cache_directory + "/weblog/show/n.html"
# ActionController::Base.page_cache_directory + "/weblog/show.html"
# and the web server will pick it up without even hitting Rails
end

Expand Down Expand Up @@ -322,7 +322,7 @@ The latest version of Action Pack can be installed with RubyGems:

Source code can be downloaded as part of the Rails project on GitHub

* https://github.com/rails/rails/tree/master/actionpack
* https://github.com/rails/rails/tree/3-2-stable/actionpack


== License
Expand Down
9 changes: 4 additions & 5 deletions actionpack/actionpack.gemspec
Expand Up @@ -18,13 +18,12 @@ Gem::Specification.new do |s|

s.add_dependency('activesupport', version)
s.add_dependency('activemodel', version)
s.add_dependency('rack-cache', '~> 1.1')
s.add_dependency('rack-cache', '~> 1.2')
s.add_dependency('builder', '~> 3.0.0')
s.add_dependency('i18n', '~> 0.6')
s.add_dependency('rack', '~> 1.3.5')
s.add_dependency('rack', '~> 1.4.0')
s.add_dependency('rack-test', '~> 0.6.1')
s.add_dependency('journey', '~> 1.0.0.rc1')
s.add_dependency('sprockets', '~> 2.1.2')
s.add_dependency('journey', '~> 1.0.1')
s.add_dependency('sprockets', '~> 2.1.3')
s.add_dependency('erubis', '~> 2.7.0')

s.add_development_dependency('tzinfo', '~> 0.3.29')
Expand Down
6 changes: 3 additions & 3 deletions actionpack/lib/abstract_controller/layouts.rb
Expand Up @@ -237,10 +237,10 @@ def conditional_layout?
#
# If the specified layout is a:
# String:: the String is the template name
# Symbol:: call the method specified by the symbol, which will return
# the template name
# Symbol:: call the method specified by the symbol, which will return the template name
# false:: There is no layout
# true:: raise an ArgumentError
# nil:: Force default layout behavior with inheritance
#
# ==== Parameters
# * <tt>layout</tt> - The layout to use.
Expand All @@ -254,7 +254,7 @@ def layout(layout, conditions = {})
conditions.each {|k, v| conditions[k] = Array(v).map {|a| a.to_s} }
self._layout_conditions = conditions

@_layout = layout || false # Converts nil to false
@_layout = layout
_write_layout_method
end

Expand Down
9 changes: 2 additions & 7 deletions actionpack/lib/abstract_controller/rendering.rb
Expand Up @@ -35,7 +35,7 @@ module Rendering
include AbstractController::ViewPaths

included do
config_accessor :protected_instance_variables, :instance_reader => false
class_attribute :protected_instance_variables
self.protected_instance_variables = []
end

Expand All @@ -59,12 +59,6 @@ def view_context_class

attr_internal_writer :view_context_class

# Explicitly define protected_instance_variables so it can be
# inherited and overwritten by other modules if needed.
def protected_instance_variables
config.protected_instance_variables
end

def view_context_class
@_view_context_class ||= self.class.view_context_class
end
Expand Down Expand Up @@ -112,6 +106,7 @@ def render_to_body(options = {})
# Find and renders a template based on the options given.
# :api: private
def _render_template(options) #:nodoc:
lookup_context.rendered_format = nil if options[:formats]
view_renderer.render(view_context, options)
end

Expand Down
3 changes: 1 addition & 2 deletions actionpack/lib/action_controller/base.rb
Expand Up @@ -121,7 +121,7 @@ module ActionController
#
# def search
# @results = Search.find(params[:query])
# case @results
# case @results.count
# when 0 then render :action => "no_results"
# when 1 then render :action => "show"
# when 2..10 then render :action => "show_many"
Expand Down Expand Up @@ -192,7 +192,6 @@ def self.without_modules(*modules)
Renderers::All,
ConditionalGet,
RackDelegation,
SessionManagement,
Caching,
MimeResponds,
ImplicitRender,
Expand Down
6 changes: 4 additions & 2 deletions actionpack/lib/action_controller/caching/actions.rb
Expand Up @@ -102,8 +102,10 @@ def caches_action(*actions)
end

def _save_fragment(name, options)
content = response_body
content = content.join if content.is_a?(Array)
content = ""
response_body.each do |parts|
content << parts
end

if caching_allowed?
write_fragment(name, content, options)
Expand Down