Added initial stab at an or scope operator #6817
Conversation
|
This fixes #5545. Thanks! |
|
Fantásticooow!! |
| # # SELECT * FROM users WHERE name = 'Alice' OR email = 'joe@example.com' | ||
| # | ||
| def or(scope) | ||
| left = self.where_values.inject {|l,r| l.and(r)} |
There was a problem hiding this comment.
this particular line makes the assumption that .and is always the 'join' for clauses. This is true until now, but if one had a scope with or joining to another scope with ors, they'd end up ands.
If there's an arel 'join clauses' method which would use correct concat here that would be handy. If not, a hint at where to find the concat used in the where to extract a method here to do it would be good.
|
Hi Loz, |
|
Yup, this is totally NOT the solution I want, which is why I put it up for some feedback. |
|
Hey @loz! Do you plan to continue to work on this? |
|
Hey @loz! it's been a month since I've heard from you, so I'm giving this a close. If you'd like to keep up with this pull, push some more commits, and I'll gladly re-open. |
This includes a test case and an implementation. I think I need some advice however as the only way I could replace the where clauses in a scope was to unscope, which will have killed other aspects, like having etc, so I'm happy to make changes if someone could advice.