Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A missing require is added to fix build. When performing rake test:isolated in actionmailer, test/base_test.rb was break. #7477

Merged
merged 1 commit into from Aug 30, 2012

Conversation

kennyj
Copy link
Contributor

@kennyj kennyj commented Aug 29, 2012

I fixed some warnings related to mime_type method's deprecation on master (#7469).

But I got some another problems.
When executing rake test:isolated in ActionMailer, test/base_test.rb was break.

 1) Failure:
test_0007_should set template content type if mail has only one part(BaseTest) [test/base_test.rb:69]:
Expected: "text/html"
Actual: "text/plain"
...

After investigating, I realized the cause of problem.
If we didn't load action_dispatch, we also didn't execute ActionView::Template::Types.delegate_to Mime
Please see also 67f55e2#L0R107.

If we delegate to Mime, build is success.

@kennyj
Copy link
Contributor Author

kennyj commented Aug 29, 2012

cc/ @drogus

@rafaelfranca
Copy link
Member

@drogus all yours

@drogus
Copy link
Member

drogus commented Aug 30, 2012

Thanks! I'm wondering why tests:isolated are not run on CI, though, is there any good reason to leave them (apart from running time?)

drogus added a commit that referenced this pull request Aug 30, 2012
A missing require is added to fix build. When performing rake test:isolated in actionmailer, test/base_test.rb was break.
@drogus drogus merged commit a0c5cc6 into rails:master Aug 30, 2012
@drogus
Copy link
Member

drogus commented Aug 30, 2012

Ok, sorry, disregard my question, I misunderstood what @kennyj was saying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants