Refactor Mime::Type
#7522
Merged
Refactor Mime::Type
#7522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is the benchmark? |
| @@ -4,7 +4,7 @@ | |||
| module Mime | |||
| class Mimes < Array | |||
| def symbols | |||
| @symbols ||= map {|m| m.to_sym } | |||
| @symbols ||= map(&:to_sym) | |||
There was a problem hiding this comment.
If we want to make it faster this is making a little slower:
user system total real
block 1.680000 0.000000 1.680000 ( 1.677796)
sym to 1.840000 0.000000 1.840000 ( 1.850888)
[1.9.3-p194 placar-admin (master)]$ ruby bm.rb
user system total real
block 1.680000 0.000000 1.680000 ( 1.680283)
sym to 1.870000 0.000000 1.870000 ( 1.873345)
[1.9.3-p194 placar-admin (master)]$ ruby bm.rb
user system total real
block 1.700000 0.000000 1.700000 ( 1.707954)
sym to 1.860000 0.000000 1.860000 ( 1.868167)
[1.9.3-p194 placar-admin (master)]$ ruby bm.rb
user system total real
block 1.860000 0.000000 1.860000 ( 1.874244)
sym to 1.930000 0.000000 1.930000 ( 1.933034)
[1.9.3-p194 placar-admin (master)]$ ruby bm.rb
user system total real
block 1.680000 0.010000 1.690000 ( 1.677366)
sym to 1.850000 0.000000 1.850000 ( 1.857757)
There was a problem hiding this comment.
I've return explicit block.
|
|
@lexmag I'm fine with the changes. I'm just wondering about the Also coul you add this benchmark in the commit message? |
|
I've added benchmark in the commit message. |
`parse` method performance improvements - ~27-33%:
accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*"
Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }}
old: 1.430000 0.000000 1.430000 ( 1.440977)
new: 0.920000 0.000000 0.920000 ( 0.921813)
|
Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parsemethod performance improvements - ~27-33%