Fixes issue #5660: Failsafe exception returns text/html and text/plain. #7636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +54,7 @@ def render_exception(env, exception) | |||
| response[1]['X-Cascade'] == 'pass' ? pass_response(status) : response | |||
| rescue Exception => failsafe_error | |||
| $stderr.puts "Error during failsafe response: #{failsafe_error}\n #{failsafe_error.backtrace * "\n "}" | |||
| FAILSAFE_RESPONSE | |||
| env['HTTP_ACCEPT'] == 'text/html' ? FAILSAFE_RESPONSE_HTML : FAILSAFE_RESPONSE_PLAIN_TEXT | |||
There was a problem hiding this comment.
It doesn't have to be, but that's probably better.
|
Nah, in theory this should never be triggered, so I am lazy to keep two versions. Why not just always return text/plain then? |
|
I can also make that change, if you think it's better. The only advantage of returning |
|
Updated. Now we only return text/plain. |
|
cc/ @josevalim |
|
@steveklabnik could you add a CHANGELOG entry? I'll merge this one. |
|
@rafaelfranca done. |
|
This pull request cannot be automatically merged. |
|
Yeah I'm an idiot, fixing now. |
It's best to just return text/plain when something has gone terribly wrong. Fixes rails#5660.
rafaelfranca
added a commit
that referenced
this pull request
Oct 2, 2012
Fixes issue #5660: Failsafe exception returns text/html and text/plain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request format is text/html then return the existing failsafe
response. For all other formats return text/plain.
The original issue points out to return JSON at the appropriate time,
however as @wycats pointed out, it's often better to return text/plain.