Support :multiple option on input tags that also have :index #8108
Conversation
| @@ -1,5 +1,9 @@ | |||
| ## Rails 4.0.0 (unreleased) ## | |||
|
|
|||
| * Support :multiple => true on an input tag that also has :index set | |||
There was a problem hiding this comment.
We don't need this changelog entry since this feature was added on master only.
There was a problem hiding this comment.
Oh, OK, I'll remove it.
So 4.0 is on a separate branch now? I'd like to get this in for Rails 4, since it's a bug fix. Should I backport it and make a separate pull request for that as well?
There was a problem hiding this comment.
4.0 is still master. Is this issue present on 3-2-stable as well? If so we will need the CHANGELOG entry.
There was a problem hiding this comment.
Yes it is present on all versions of Rails 3.
OK I'll make a separate pull for 3-2-stable with a CHANGELOG entry, would that be enough?
There was a problem hiding this comment.
You don't need to. I'll merge this and cherry-pick with the CHANGELOG message that you added here.
But we will need to wait the 3.2.9 release to backport it.
Thanks
When you have an explicit index set, then when you build an input tag with :multiple => true, it doesn't add [] to the end of its name, although it should.
…nstance-tag Support :multiple option on input tags that also have :index
…nstance-tag Support :multiple option on input tags that also have :index Conflicts: actionpack/lib/action_view/helpers/tags/base.rb actionpack/lib/action_view/helpers/tags/collection_check_boxes.rb
When you have an explicit index set, then when you build an input tag with :multiple => true, it doesn't add [] to the end of its name, although it should.