Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENV['RACK_ENV'] support to rake runner/console/server. #8427

Merged
merged 1 commit into from Dec 5, 2012

Conversation

kennyj
Copy link
Contributor

@kennyj kennyj commented Dec 5, 2012

rake dbconsole support ENV['RACK_ENV']. And railties/lib/rails.rb also support one.

 87     def env
 88       @_env ||= begin
 89         ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
 90         ActiveSupport::StringInquirer.new(ENV["RAILS_ENV"])
 91       end
 92     end

I thinks we should use RACK_ENV for usefulness and consistency.

rafaelfranca added a commit that referenced this pull request Dec 5, 2012
Add ENV['RACK_ENV'] support to rake runner/console/server.
@rafaelfranca rafaelfranca merged commit ddd4fac into rails:master Dec 5, 2012
@rafaelfranca
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants