Fixed a method redefine warning #8467

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@gsphanikumar

While running the tests in activemodel the below warning is fixed.

/rails/activesupport/lib/active_support/core_ext/hash/deep_merge.rb:16: warning: method redefined; discarding old deep_merge!

I am not sure if using undef in the source is fine.

@steveklabnik
Member

I'm 👎 on this, we should be handling this upstream, not undefining a method here.

I'm pretty sure it's bundler that's causing this, yes? I think bundler HEAD fixes these warnings already. @indirect?

@indirect
Member
indirect commented Dec 9, 2012

I think so. If not, I'd love a patch. :)

On Dec 9, 2012, at 9:43 AM, Steve Klabnik notifications@github.com wrote:

I'm on this, we should be handling this upstream, not undefining a method here.

I'm pretty sure it's bundler that's causing this, yes? I think bundler HEAD fixes these warnings already. @indirect?


Reply to this email directly or view it on GitHub.

@steveklabnik
Member

Cool, closing this, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment