Fix error raised when assigning NaN to an integer column #8781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,10 @@ | |||
| ## Rails 4.0.0 (unreleased) ## | |||
|
|
|||
| * Fix FloatDomainError when setting integer column to NaN, or anything that | |||
| responds to to_i but raises an exception on calling it. Fixes #8757. | |||
There was a problem hiding this comment.
I'd amend the issue number and you name in the changelog entry for the previous fix, since it was not released yet.
There was a problem hiding this comment.
Sounds good, excellent. I'll amend the commit.
|
Very good. Just a minor comment. |
Also covers any non-castable case by returning nil, which is in-line with the intention of the former implementation, but covers the odd cases which respond to to_i but raise an error when it's called, such as NaN, Infinity and -Infinity. Fixes #8757
|
All set. @rafaelfranca thanks for the review and advice on the little issue. |
rafaelfranca
added a commit
that referenced
this pull request
Jan 6, 2013
…_error_fix Fix error raised when assigning NaN to an integer column
|
@trisweb Thank YOU for the report and fix. |
rafaelfranca
pushed a commit
that referenced
this pull request
Jan 6, 2013
Also covers any non-castable case by returning nil, which is in-line with the intention of the former implementation, but covers the odd cases which respond to to_i but raise an error when it's called, such as NaN, Infinity and -Infinity. Fixes #8757 Backport of #8781 Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/column_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes integer casting cover any non-castable case by returning
nil, which is in-line with the intention of the former implementation in 3525a9b, but covers the odd cases which respond toto_ibut raise an error when it's called, such asNaN,Infinityand-Infinity.Those are the only ones I know of, but it's possible other objects could raise errors on
to_i, which is the reason for the generic rescue. (Note that this generic rescue was also the behavior pre-3.2.8, except that the value was interpreted as a boolean instead—fixed in 96a13fc—after this pull it will be more correctly and consistently interpreted asnil).Fixes #8757 (see that issue for full description)