Fix #8832 - Parse '{"person":[]}' JSON/XML as {'person' => []}. #9111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if v.size > 0 && v.all?(&:nil?) | ||
| hash[k] = nil | ||
| next | ||
| end |
There was a problem hiding this comment.
It looks like your code will convert this JSON:
{"person":[null]}
to this Ruby hash:
{"person": nil}
Is that right?
There was a problem hiding this comment.
Yes, that's right.
After thinking about it some more, I personally think [null] is a valid query, and the problem should be solved with something like .query_present?, that returns false for "", nil, [], [nil], [""], etc.
|
3.0 stable does not receive bug fixes any more, so I cannot accept this, sorry. |
tenderlove
added a commit
that referenced
this pull request
Jan 30, 2013
Fix #8832 - Parse '{"person":[]}' JSON/XML as {'person' => []}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submitting @ndbroadbent 's patch for the 3.0 stable branch, as the bug introduced by the fix for CVE-2013-0155 applies to 3.0 as well
please see #8862 for details on the issue