remove duplicated number_helper tests in AP. They are already in AS. #9457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosantoniodasilva @rafaelfranca could you take a look? |
| assert_equal("(800) 555-1212", number_to_phone(8005551212, {:area_code => true})) | ||
| assert_equal("", number_to_phone("", {:area_code => true})) | ||
| assert_equal("800 555 1212", number_to_phone(8005551212, {:delimiter => " "})) | ||
| assert_equal(nil, number_to_phone(nil)) |
There was a problem hiding this comment.
This can be the 1st assertion.
|
I agree there's some sort of duplication between both, they were left in AP as a safety check I guess since the originals wehere there (and is where most people will use them from). Anyway, we can kill some no problem, just make sure to leave a handful for each helper :) |
With 155cd5e the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing. I removed all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP.
* use 1.9 style hash syntax * don't use brances on assert_equal * prefere " over '
carlosantoniodasilva
added a commit
that referenced
this pull request
Feb 27, 2013
…ests Remove duplicated number_helper tests in AP. They are already in AS. With 155cd5e the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing. This removes all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP. Also cleanup some of the number helper tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 155cd5e the number_helpers were moved into AS all the tests were copied over
but the tests in AP were not deleted. This is confusing.
I removed all duplicated tests and reorganized the tests in AP to only test the
functionality, that is added in AP.