Created a layer of abstraction for the valid type checking in schema dumper #9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert @conn.valid_type?(column.type) | ||
| end | ||
|
|
||
| def test_invalid_column |
There was a problem hiding this comment.
the naming seems confusing to me: test_invalid_column but it still returns true. I think this test name would be a good palce to say why the sqlite3 adapter always return true.
|
should valid_type? be made into an API method on abstract adapter? |
…dumper. Now, connection handles the check for valid types so that each database can handle the changes individually.
|
Merged at c2e2031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, connection handles the check for valid types so that each database can handle the changes individually.