Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis test matrix #421

Closed
wants to merge 1 commit into from
Closed

Update travis test matrix #421

wants to merge 1 commit into from

Conversation

gssbzn
Copy link

@gssbzn gssbzn commented Oct 2, 2018

Drop support for EOL version of ruby and add support for 2.5
Add support for rails 5.2

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Drop support for EOL version of ruby and add support for 2.5
Add support for rails 5.2

Some updates needed for travis
@gssbzn
Copy link
Author

gssbzn commented Oct 3, 2018

All test should be passing now, that took more effort than I was expecting, all warnings should be gone from travis as well taking some of the changes from #413

For some reason I had to disable the cache of bundler or travis would error with missing gem errors, if someone has a better idea on how to solve that let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants