Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method failed_with is defined repeatedly #89

Closed
tnclong opened this issue Dec 25, 2023 · 1 comment · Fixed by #90
Closed

Method failed_with is defined repeatedly #89

tnclong opened this issue Dec 25, 2023 · 1 comment · Fixed by #90

Comments

@tnclong
Copy link

tnclong commented Dec 25, 2023

https://github.com/basecamp/solid_queue/blob/282d75d9b6821b5e196db259a5f6bea43d6fe6d2/app/models/solid_queue/job/executable.rb#L53C11-L53C22
@rosa
Copy link
Member

rosa commented Dec 25, 2023

Oh ha! Thanks a lot @tnclong! Would you like to open a pull request removing one of the repeated occurrences?

justinko added a commit to justinko/solid_queue that referenced this issue Dec 25, 2023
@justinko
Clean up executable.rb
c026e7f 
Closes rails#89
@justinko justinko mentioned this issue Dec 25, 2023
Merged
justinko added a commit to justinko/solid_queue that referenced this issue Dec 25, 2023
@justinko
Clean up executable.rb
56ea230 
Closes rails#89
@rosa rosa closed this as completed in #90 Dec 26, 2023
rosa pushed a commit that referenced this issue Dec 26, 2023
@justinko @rosa
Clean up executable.rb
476a42b 
Closes #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up executable.rb justinko/solid_queue
2 participants
@rosa @tnclong