-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Supervisor only when puma is fully booted. #86
Conversation
@rosa I'm having hard time trying to update - sqlite3 (1.5.4)
- mini_portile2 (~> 2.8.0)
+ sqlite3 (1.5.4-arm64-darwin)
+ sqlite3 (1.5.4-x86_64-linux) so please let me know if you know how to fix it or you can try to update it yourself (we need to add puma to Gemfile.lock) |
@nashby Here's the updated Gemfile.lock that includes Puma:
|
@nashby I can reproduce your issue with Ruby 3.0.3 ... try 3.2.2 and it should resolve. |
@justinko indeed, thanks! |
test/integration/puma/plugin_test.rb
Outdated
end | ||
|
||
teardown do | ||
Process.kill 'INT', @pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A super minor nit, just to match other usages in the codebase:
Process.kill 'INT', @pid | |
Process.kill :INT, @pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much! 🙌
To be able to use app's code we need to wait for puma to boot before we start SolidQueue's supervisor.
closes #77