You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Feb 26, 2013, at 9:12 AM, Rafael Mendonça França ***@***.*** wrote:
@josh is there any case where people don't want this?
—
Reply to this email directly or view it on GitHub.
The reason will be displayed to describe this comment to others. Learn more.
hmm, got it. This patch is fixing a problem to people who choose to follow the conventions. They should be able to add sprockets-rails and the things will just work.
I'm not used to this code base, so if we have a way to do it without penalize the people who choose to follow the conventions, please go ahead and make the change.
Your thoughts are always valuable and welcome here.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gross.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People should use bundler env vars or flags when invoking assets:precompile if they want to do this.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josh is there any case where people don't want this?
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, got it. This patch is fixing a problem to people who choose to follow the conventions. They should be able to add sprockets-rails and the things will just work.
I'm not used to this code base, so if we have a way to do it without penalize the people who choose to follow the conventions, please go ahead and make the change.
Your thoughts are always valuable and welcome here.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most wish this was a rails initialization concern in that case.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guilleiguaran could you investigate it?
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bbc19aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in 59922ec