Asset names passed to helpers should not include the "/assets/" prefix. Error

[nottewae]

Asset names passed to helpers should not include the "/assets/" prefix. Instead of "/assets/top_fone.png", use "top_fone.png"

---

slim:
3: = image_tag asset_path("top_fone.png"), class:"col-md-12"

---

in gem 'sprockets-rails','= 2.1.4' only

[matthewd]

Hmm. You can avoid the error by not doing a double-lookup: image_tag already handles asset paths; there's no need to use asset_path as well:

= image_tag "top_fone.png", class: "col-md-12"

(or, of course, turn raise_runtime_errors off.)

But it's true that this is not the sort of thing we're actually trying to warn about... our worry is people incorrectly doing image_tag("/assets/top_fone.png") directly.

[jcoyne]

@matthewd Seems like a good change, but pushing it out in a patch level release seems to violate SemVer.

[tagliala]

same here, this change breaked:

= javascript_include_tag '//oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js', asset_path('respond.js')

and I didn't get the reason at first because the warning message says:

Asset names passed to helpers should not include the "/assets/" prefix. Instead of "/assets/respond.js", use "respond.js"

(like I was doing)

I agree with @jcoyne that it is a breaking change

[rebelwarrior]

I agree with @jcoyne this is a breaking change.

[josh]

Any new flag like that should have go into a minor release. Though, the flag shouldn't have been enabled by default so it shouldn't have been backwards breaking.