-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset names passed to helpers should not include the "/assets/" prefix. Error #167
Comments
Hmm. You can avoid the error by not doing a double-lookup:
(or, of course, turn But it's true that this is not the sort of thing we're actually trying to warn about... our worry is people incorrectly doing |
@matthewd Seems like a good change, but pushing it out in a patch level release seems to violate SemVer. |
same here, this change breaked: = javascript_include_tag '//oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js', asset_path('respond.js') and I didn't get the reason at first because the warning message says:
(like I was doing) I agree with @jcoyne that it is a breaking change |
I agree with @jcoyne this is a breaking change. |
Any new flag like that should have go into a minor release. Though, the flag shouldn't have been enabled by default so it shouldn't have been backwards breaking. |
Asset names passed to helpers should not include the "/assets/" prefix. Instead of "/assets/top_fone.png", use "top_fone.png"
slim:
3: = image_tag asset_path("top_fone.png"), class:"col-md-12"
in gem 'sprockets-rails','= 2.1.4' only
The text was updated successfully, but these errors were encountered: