Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling in Ruby and Markdown files #699

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Fix spelling in Ruby and Markdown files #699

merged 1 commit into from
Mar 8, 2021

Conversation

jbampton
Copy link
Contributor

No description provided.

gmcgibbon
gmcgibbon reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the changelog entry for documentation changes. Could you please remove it? Thanks!

@jbampton jbampton requested a review from gmcgibbon March 5, 2021 10:11
gmcgibbon
gmcgibbon approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmcgibbon gmcgibbon merged commit 2c38d99 into rails:master Mar 8, 2021
@jbampton jbampton deleted the fix-spelling branch March 8, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcgibbon gmcgibbon gmcgibbon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbampton @gmcgibbon