Remove skips on truffleruby, latest truffleruby passes the whole test suite [changelog skip] #778
Conversation
eregon
commented
Jan 25, 2023
eregon
commented
- Since Sprockets test_compile_erb_template_that_depends_on_env test fails oracle/truffleruby#2810 was fixed.
eregon
changed the title
| @@ -52,7 +52,9 @@ def test_fail_to_unmarshal_older_major_version | |||
| end | |||
|
|
|||
| def test_fail_to_unmarshal_not_enough_data | |||
| skip "TypeError on TruffleRuby" if RUBY_ENGINE == "truffleruby" | |||
| if RUBY_ENGINE == 'truffleruby' and Gem::Version.new(RUBY_ENGINE_VERSION) < Gem::Version.new('23.0.0.a') | |||
There was a problem hiding this comment.
Alternative: if we don't want these checks and just want to remove the skips, then we test only on truffleruby-head, and not on truffleruby (release), until the next release.
There was a problem hiding this comment.
How far away until the next release? As in it is worth waiting for that next release and remove all the skips?
There was a problem hiding this comment.
Only in April, in ~2 months: https://www.graalvm.org/release-notes/release-calendar/
I'd much rather it's merged before that if possible.
The current PR is ideal because it doesn't need any change once 23.0 is released.
There was a problem hiding this comment.
Fine, by me, but I'd appreciate if you could open another PR later to remove these.
There was a problem hiding this comment.
OK, I created a reminder to do that after the 23.0 release.
eregon
changed the title
