Compile aliased index assets. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +167,9 @@ def resolve_index_under_path(load_path, logical_name, mime_exts) | |||
| if directory?(dirname) | |||
| candidates = find_matching_path_for_extensions(dirname, "index", mime_exts) | |||
| end | |||
| return candidates, deps | |||
| return candidates.map { |c| | |||
| { filename: c[0], type: c[1], index_alias: c[0].sub(/\/index/, '') } | |||
There was a problem hiding this comment.
Is there any case were a string like assets/index/foo.js end up in c[0]? I think we can use gsub here and also use something like /\/index.\w{2,4}$/.
There was a problem hiding this comment.
I'll write a test for that.
rafaelfranca
added a commit
that referenced
this pull request
Aug 10, 2015
Compile aliased index assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose ot this code is to give the possibility to compile the alias variant of an 'index' asset.
Suppose we have a file
something/index.js. Sprockets can yield this file in two ways at the moment:The thing is that when we precompile our asset we get only the 'index' version of it, regardless of how we list it in the manifest. This is because the location of the compiled file is derived from the logical path of the asset.
So, what this PR introduces is the ability do get a desired logical path depending on the way we request the asset:
This gives us the possibility to compile both versions, depending on our needs.