Migrate to Sprockets 4. #21132
Merged
Migrate to Sprockets 4. #21132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| //= link_tree ./images | |||
| //= link ./javascripts/application | |||
There was a problem hiding this comment.
I remember we had problems because we didn't make explicit the extension right?
Andreis13
force-pushed
the
sprockets-4
branch
2 times, most recently
from
a0664f8
to
c74a9c4
Compare
| @@ -20,7 +20,7 @@ gem 'turbolinks' | |||
| gem 'arel', github: 'rails/arel', branch: 'master' | |||
| gem 'mail', github: 'mikel/mail' | |||
|
|
|||
| gem 'sprockets', '~> 3.0.0.rc.1' | |||
| gem 'sprockets', github: 'rails/sprockets', branch: 'master' | |||
There was a problem hiding this comment.
Do we need to add sass-rails master here?
There was a problem hiding this comment.
Perhaps we could add it here also, it is already present in the Gemfiles of the generated applications and I don't fully understand what gems should be present in Gemfile for the rails gem itself, so I didn't include it because no test was failing because of this.
There was a problem hiding this comment.
If we need on generate Gemfiles we need here too. The Railties tests use this Gemfile instead of the generated one.
Andreis13
force-pushed
the
sprockets-4
branch
4 times, most recently
from
754d76a
to
1926b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: rails/sprockets#85
cc: @rafaelfranca