This repository has been archived by the owner on Aug 17, 2017. It is now read-only.
Update README.rdoc #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more specific/detailled example for nested parameters showcasing the extra edge-case of allowing for deep nesting of an array of permitted scalar values.
|
cc @fxn |
|
It is a good addition, but I would add it to the existing key, rather than replacing it. |
|
@chikamichi any chance of updating this in the way @fxn asked? |
|
@steveklabnik done, but I think the example is somewhat bloated now :) My initial goal was to mention the syntax to be used to allow for an array of arbitrary scalar values (using the {:foo => []} trick, but nested, which was/is not so obvious). Maybe this could be split, or worded differently? |
|
I think it's OK, it is a generic example depicting different declarations and nestings. Thanks for the update. |
|
I think it's fine for now. We already have a few simple examples up top, having a more complex one is good. Thank you! ❤️ |
|
You're welcome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more specific/detailed example for nested parameters showcasing the extra edge-case of allowing for deep nesting of an array of permitted scalar values.