Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password prompt through shell.ask("Pass: ", :password => true) #209

Closed
wants to merge 1 commit into from

Conversation

rykov
Copy link

@rykov rykov commented Jan 14, 2012

Extracted carefully from the Heroku gem, this change adds cross-platform support for password requests. I am not sure about the best way to test this. Nor do I have a Windows box to test the Windows execution path.

@technicalpickles
Copy link

Was working on a gem this evening, and would have loved something like this 👍

@eventualbuddha
Copy link
Contributor

I'm a little torn between saying that you should use something like highline and accepting this. We do already have a fair number of shell input functionality, and this seems to round it out pretty well. I could use a second opinion, @sferik.

If we did accept this I'd probably change the method name to something else, like ask_for_password.

@christophermanning
Copy link

Adding an echo option to ask could be an option too ask("Password: ", :echo => false)

#108

@technicalpickles
Copy link

@christophermanning I like that idea, plus it wouldn't require too many API changes (hopefully), just a new option.

@eventualbuddha
Copy link
Contributor

I like echo: false, too.

@eventualbuddha
Copy link
Contributor

@rykov, want to take a stab at echo: false?

@vanm
Copy link

vanm commented May 23, 2013

@eventualbuddha I took a shot at a new option for controlling echo in PR #332

@petems
Copy link

petems commented Aug 18, 2013

Is this PR still live? I'm looking for a password entering option for my gem, would be cool to get this or the "echo => false" implementation merged in 👍

@eventualbuddha
Copy link
Contributor

Closed in favor of #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants