Prefer to use URI.open and File.open instead of Kernel.open #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the |
|
Oh! Thanks to share it. |
|
Should we enable Security/Open in RuboCop configuration file too? |
|
馃憤 or add CodeQL actions. |
|
That too, just thought of RuboCop since it's already used. |
|
Can you please rebase this PR? |
hsbt
force-pushed
the
suppress-warning-codeql
branch
from
47d4a06
to
c88f213
Compare
hsbt
force-pushed
the
suppress-warning-codeql
branch
from
c88f213
to
16db563
Compare
|
@rafaelfranca done 馃殌 |
|
Thanks @rafaelfranca 鉂わ笍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 CodeQL detects "Use of
Kernel.openorIO.readwith a non-constant value" warnings in https://github.com/ruby/ruby. I hope to suppress them.