Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing tables with borders and indentation #861

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

p8
Copy link
Member

@p8 p8 commented Aug 25, 2023

When printing tables with borders and indentation the resulting markup was incorrect.
Instead of adding the indentation to the format of the first cell, with indent the whole line.

Before:

  +------  +--------  +-------+
|   Name | Number | Color |
|   Erik |      1 | green |
  +------  +--------  +-------+

After

  +------+--------+-------+
  | Name | Number | Color |
  | Erik |      1 | green |
  +------+--------+-------+

@p8 p8 force-pushed the fix/table-indentation-with-borders branch 2 times, most recently from 2d7e3d9 to 9bb27bf Compare August 25, 2023 09:26
When printing tables with borders and indentation the resulting markup
was incorrect. Instead of adding the indentation to the format of the
first cell, with indent the whole line.

Before:
```
  +------  +--------  +-------+
|   Name | Number | Color |
|   Erik |      1 | green |
  +------  +--------  +-------+
```

After
```
  +------+--------+-------+
  | Name | Number | Color |
  | Erik |      1 | green |
  +------+--------+-------+
```
@rafaelfranca rafaelfranca force-pushed the fix/table-indentation-with-borders branch from 9bb27bf to ec2aa61 Compare October 18, 2023 18:58
@rafaelfranca rafaelfranca merged commit 4f86670 into rails:main Oct 18, 2023
7 checks passed
@p8 p8 deleted the fix/table-indentation-with-borders branch December 30, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants