Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MutationObserver instead of Mutation Events #297

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

mikelkew
Copy link

As raised in #288, Mutation Events have been deprecated in favour of MutationObserver, causing deprecation warnings to be shown in the Firefox dev console.

This PR refactors the current implementation to use MutationObserver instead, and preserves the existing functionality.

Resolves #288.

Mutation Events have been deprecated in favour of MutationObserver.
This change prevents deprecation warnings from showing in browser
dev consoles.
@gsamokovarov
Copy link
Collaborator

Thanks!

@gsamokovarov gsamokovarov merged commit 008e6c6 into rails:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning for web console in Firefox
2 participants