Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain paths when packing images #1964

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Maintain paths when packing images #1964

merged 1 commit into from
Mar 3, 2019

Conversation

gaffneyc
Copy link
Contributor

This reverts #1914 which attempted to "simplify" the file paths but
introduced cases where multiple files could overwrite each other.

This is an alternate to #1950, reverting just the copying change but
maintaining media as a top level directory.

Fixes #1938
Closes #1950

@gaffneyc
Maintain paths when packing images
2dd61ed 
This reverts #1914 which attempted to "simplify" the file paths but
introduced cases where multiple files could overwrite each other.

This is based on feedback from #1950 where the team wants to maintain
`media` as a base directory.

Fixes #1938
Closes #1950
@gaffneyc gaffneyc mentioned this pull request Feb 26, 2019
Closed
@klausbadelt klausbadelt mentioned this pull request Feb 28, 2019
Merged
@guilleiguaran guilleiguaran merged commit 86641b4 into rails:master Mar 3, 2019
@gaffneyc gaffneyc deleted the fix-1938 branch March 3, 2019 17:14
klausbadelt added a commit to klausbadelt/webpacker that referenced this pull request Mar 12, 2019
@klausbadelt
updated to reflect 0b86cad and PR rails#1964
b7221df
gauravtiwari pushed a commit that referenced this pull request Mar 18, 2019
@klausbadelt @gauravtiwari
Documentation asset.md update: Add needed require.context to use pack…
554221c 
… helpers (#1969)

* Add needed require.context to use pack helpers

As discussed in #705, the documentation is missing the essential addition of require.context in your app js to make the `asset_pack_path` and `image_pack_tag`

* updated to reflect 0b86cad and PR #1964
@taylorthurlow taylorthurlow mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilleiguaran guilleiguaran guilleiguaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaffneyc @guilleiguaran