Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js dependencies #2428

Merged
merged 4 commits into from
Mar 20, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.16.0
10.13.0
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Webpacker

[![Build Status](https://travis-ci.org/rails/webpacker.svg?branch=master)](https://travis-ci.org/rails/webpacker)
[![node.js](https://img.shields.io/badge/node-%3E%3D%208.16.0-brightgreen.svg)](https://www.npmjs.com/package/@rails/webpacker)
[![node.js](https://img.shields.io/badge/node-%3E%3D%2010.13.0-brightgreen.svg)](https://www.npmjs.com/package/@rails/webpacker)
[![Gem](https://img.shields.io/gem/v/webpacker.svg)](https://rubygems.org/gems/webpacker)

Webpacker makes it easy to use the JavaScript pre-processor and bundler
Expand Down Expand Up @@ -52,7 +52,7 @@ in which case you may not even need the asset pipeline. This is mostly relevant

* Ruby 2.3+
* Rails 4.2+
* Node.js 8.16.0+
* Node.js 10.13.0+
* Yarn 1.x+


Expand Down
42 changes: 21 additions & 21 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@
"lib/install/config/webpacker.yml"
],
"engines": {
"node": ">=8.9",
"node": ">=10.13.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with the version update for Node.js because...

👍 I agree with this part

"yarn": ">=1 <2"
},
"dependencies": {
"@babel/core": "^7.7.2",
"@babel/plugin-proposal-class-properties": "^7.7.0",
"@babel/plugin-proposal-object-rest-spread": "^7.6.2",
"@babel/plugin-syntax-dynamic-import": "^7.2.0",
"@babel/plugin-transform-destructuring": "^7.6.0",
"@babel/plugin-transform-regenerator": "^7.7.0",
"@babel/plugin-transform-runtime": "^7.6.2",
"@babel/preset-env": "^7.7.1",
"@babel/runtime": "^7.7.2",
"@babel/core": "^7.8.6",
"@babel/plugin-proposal-class-properties": "^7.8.3",
"@babel/plugin-proposal-object-rest-spread": "^7.8.3",
"@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-destructuring": "^7.8.3",
"@babel/plugin-transform-regenerator": "^7.8.3",
"@babel/plugin-transform-runtime": "^7.8.3",
"@babel/preset-env": "^7.8.6",
"@babel/runtime": "^7.8.4",
"babel-loader": "^8.0.6",
"babel-plugin-dynamic-import-node": "^2.3.0",
"babel-plugin-macros": "^2.6.1",
"babel-plugin-macros": "^2.8.0",
"case-sensitive-paths-webpack-plugin": "^2.2.0",
"compression-webpack-plugin": "^3.0.1",
"core-js": "^3.4.0",
"css-loader": "^3.2.0",
"file-loader": "^4.2.0",
"core-js": "^3.6.4",
"css-loader": "^3.4.1",
"file-loader": "^5.0.2",
"flatted": "^2.0.1",
"glob": "^7.1.6",
"js-yaml": "^3.13.1",
"mini-css-extract-plugin": "^0.8.0",
"mini-css-extract-plugin": "^0.9.0",
"node-sass": "^4.13.1",
"optimize-css-assets-webpack-plugin": "^5.0.3",
"path-complete-extname": "^1.0.0",
Expand All @@ -43,20 +43,20 @@
"postcss-preset-env": "^6.7.0",
"postcss-safe-parser": "^4.0.1",
"regenerator-runtime": "^0.13.3",
"sass-loader": "7.3.1",
"style-loader": "^1.0.0",
"sass-loader": "^7.3.1",
"style-loader": "^1.1.2",
"terser-webpack-plugin": "^2.3.4",
"webpack": "^4.41.3",
"webpack": "^4.41.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gauravtiwari, does it make sense to support this PR? Maybe it would be better to break it into smaller ones?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pustovalov Yep it does. I was just concerned if there is going to be any breaking changes? I guess everything looks good except file loader node version requirements? https://github.com/webpack-contrib/file-loader/releases/tag/v5.0.0

Thanks for working on this and sorry about the delay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, looks like breaking change only in file-loader

"webpack-assets-manifest": "^3.1.1",
"webpack-cli": "^3.3.10",
"webpack-sources": "^1.4.3"
},
"devDependencies": {
"eslint": "^6.6.0",
"eslint": "^6.8.0",
"eslint-config-airbnb": "^18.0.1",
"eslint-plugin-import": "^2.18.2",
"eslint-plugin-import": "^2.19.1",
"eslint-plugin-jsx-a11y": "^6.2.3",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react": "^7.17.0",
"jest": "^24.9.0"
},
"jest": {
Expand Down
Loading