Update js dependencies #2428

pustovalov · 2020-01-07T22:57:28Z

https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md

minimum required nodejs version is 10.13.0

pustovalov · 2020-01-07T23:08:28Z

I'd rather switch from 8.16.0 to 12.14.1. This is current LTS version

Active LTS Start - 2019-10-21

WDYT?

jakeNiemiec · 2020-01-08T19:01:32Z

Just a few questions. Why is terser under resolutions? "terser-webpack-plugin": "^2.3.1"

Should we avoid wrapping breaking changes in a commit like "Update js dependencies". Remember that users can fine-tune the loaders in environment.js. This is unlikely, but it has happened with other loaders in the past couple months.

pustovalov · 2020-01-08T20:12:25Z

Just a few questions. Why is terser under resolutions? "terser-webpack-plugin": "^2.3.1"

Webpacker use "terser-webpack-plugin": "^2.3.1"
https://github.com/rails/webpacker/blob/master/package.json#L48

And webpack has this dependency:
terser-webpack-plugin "^1.4.3"
https://github.com/rails/webpacker/blob/master/yarn.lock#L8101

a separate dependency was introduced in this commit

0d36af9#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L42

and then updated in this commit

13756f1#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L48

as a result, we have two terser-webpack-plugin:
1.4.3
https://github.com/rails/webpacker/blob/master/yarn.lock#L7615

2.3.1
https://github.com/rails/webpacker/blob/master/yarn.lock#L7630

I think terser-webpack-plugin will not be updated for webpack 4, because:

https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md#-breaking-changes

2.0.0 (2019-09-05)
⚠ BREAKING CHANGES
minimum require Node.js version is 8.9.0

Webpack 4 supporting node >= 6.11
https://github.com/webpack/webpack/blob/webpack-4/package.json#L87

I use resolutions for terser-webpack-plugin with webpacker in my project, and all works fine

pustovalov · 2020-01-08T20:19:12Z

Remember that users can fine-tune the loaders in environment.js

yea, but webpacker in default configuration does not use those parameters that were changed.

I think with the version update for Node.js, because

The Node.js 8.x Maintenance LTS cycle will expire on December 31, 2019 
- which means that Node 8 won’t get any more updates, bug fixes or security patches.

https://blog.risingstack.com/update-nodejs-8-end-of-life-no-support/

and also with this PR: #2415

We can also update and loaders

jakeNiemiec · 2020-01-10T00:23:46Z

package.json

    "jest": "^24.9.0"
  },
+  "resolutions": {
+    "terser-webpack-plugin": "^2.3.1"
+  },


as a result, we have two terser-webpack-plugin ... I think terser-webpack-plugin will not be updated for webpack 4

It is ok that we have 2 versions of terser. Webpack needs to use the version of terser that it was built to support. There is no need to micromanage the lock file 👍.

jakeNiemiec · 2020-01-10T00:24:46Z

package.json

@@ -43,22 +43,25 @@
    "postcss-preset-env": "^6.7.0",
    "postcss-safe-parser": "^4.0.1",
    "regenerator-runtime": "^0.13.3",
-    "sass-loader": "7.3.1",
-    "style-loader": "^1.0.0",
+    "sass-loader": "^8.0.0",


yea, but webpacker in default configuration does not use those parameters that were changed...We can also update and loaders

This will break things for users that chose to use those parameters since we can only update loaders in our own codebase. We could have changelog entry that informs users how to migrate their environment.js, but this would need to be a breaking change.

jakeNiemiec · 2020-01-10T00:27:59Z

package.json

@@ -8,31 +8,31 @@
    "lib/install/config/webpacker.yml"
  ],
  "engines": {
-    "node": ">=8.16.0",
+    "node": ">=10.13.0",


I think with the version update for Node.js because...

👍 I agree with this part

jakeNiemiec

Thanks for those changes.

kimyu92

Is there anything that I can help out to push this through the pipeline?

package.json

changes

kimyu92 · 2020-03-20T02:59:20Z

package.json

    "terser-webpack-plugin": "^2.3.4",
-    "webpack": "^4.41.3",
+    "webpack": "^4.41.5",


https://github.com/webpack/webpack/releases/tag/v4.42.0

Hey @gauravtiwari, does it make sense to support this PR? Maybe it would be better to break it into smaller ones?

Thanks @pustovalov Yep it does. I was just concerned if there is going to be any breaking changes? I guess everything looks good except file loader node version requirements? https://github.com/webpack-contrib/file-loader/releases/tag/v5.0.0

Thanks for working on this and sorry about the delay.

you are right, looks like breaking change only in file-loader

gauravtiwari · 2020-03-20T11:19:00Z

If you could double check this and update. I will merge and make a release later today 👍

Thank you all 🙏

gauravtiwari · 2020-03-20T12:11:58Z

thanks @pustovalov

amoshydra · 2020-07-21T10:51:47Z

This PR bumped file-loader version from 4 to 5 which

switch to ES modules by default (the option esModule is true by default)
-- https://github.com/webpack-contrib/file-loader/blob/2a18cba98f1e4bd64734791a657e8acff4b11fac/CHANGELOG.md

This broke asset loading mentioned in #2613

pustovalov force-pushed the js-dep branch from beedf1a to 8010bcc Compare January 7, 2020 23:07

pustovalov force-pushed the js-dep branch 2 times, most recently from cbc2d8e to 032d937 Compare January 7, 2020 23:22

jakeNiemiec requested changes Jan 10, 2020

View reviewed changes

pustovalov force-pushed the js-dep branch from 0715bd4 to f17970d Compare January 10, 2020 01:01

jakeNiemiec previously approved these changes Jan 10, 2020

View reviewed changes

Update js dependencies

51dcaea

pustovalov force-pushed the js-dep branch from d26008b to 51dcaea Compare February 26, 2020 22:05

kimyu92 reviewed Mar 4, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

Update babel to 7.8.6

f4f6a1e

kimyu92 reviewed Mar 20, 2020

View reviewed changes

pustovalov added 2 commits March 20, 2020 13:45

Merge branch 'master' into js-dep

e5e53e2

Update babel and webpack

6f5ba5a

gauravtiwari merged commit b033d55 into rails:master Mar 20, 2020

This was referenced Mar 15, 2021

Bump webpacker from 4.3.0 to 5.2.1 boiyelove/ecommerce#15

Closed

Bump @rails/webpacker from 4.2.2 to 5.2.1 boiyelove/ecommerce#18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update js dependencies #2428

Update js dependencies #2428

pustovalov commented Jan 7, 2020 •

edited

Loading

pustovalov commented Jan 7, 2020

jakeNiemiec commented Jan 8, 2020

pustovalov commented Jan 8, 2020 •

edited

Loading

pustovalov commented Jan 8, 2020 •

edited

Loading

jakeNiemiec Jan 10, 2020

jakeNiemiec Jan 10, 2020

jakeNiemiec Jan 10, 2020

jakeNiemiec left a comment

kimyu92 left a comment

kimyu92 Mar 20, 2020

pustovalov Mar 20, 2020

gauravtiwari Mar 20, 2020

pustovalov Mar 20, 2020

gauravtiwari commented Mar 20, 2020

gauravtiwari commented Mar 20, 2020

amoshydra commented Jul 21, 2020

Update js dependencies #2428

Update js dependencies #2428

Conversation

pustovalov commented Jan 7, 2020 • edited Loading

pustovalov commented Jan 7, 2020

jakeNiemiec commented Jan 8, 2020

pustovalov commented Jan 8, 2020 • edited Loading

pustovalov commented Jan 8, 2020 • edited Loading

jakeNiemiec Jan 10, 2020

Choose a reason for hiding this comment

jakeNiemiec Jan 10, 2020

Choose a reason for hiding this comment

jakeNiemiec Jan 10, 2020

Choose a reason for hiding this comment

jakeNiemiec left a comment

Choose a reason for hiding this comment

kimyu92 left a comment

Choose a reason for hiding this comment

kimyu92 Mar 20, 2020

Choose a reason for hiding this comment

pustovalov Mar 20, 2020

Choose a reason for hiding this comment

gauravtiwari Mar 20, 2020

Choose a reason for hiding this comment

pustovalov Mar 20, 2020

Choose a reason for hiding this comment

gauravtiwari commented Mar 20, 2020

gauravtiwari commented Mar 20, 2020

amoshydra commented Jul 21, 2020

pustovalov commented Jan 7, 2020 •

edited

Loading

pustovalov commented Jan 8, 2020 •

edited

Loading

pustovalov commented Jan 8, 2020 •

edited

Loading