Do not monkey patch the app's YAML #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeYAML provides a way to avoid monkey-patching the `YAML` object. This should be used to avoid overwriting the application's `YAML`.
mshibuya
added a commit
that referenced
this pull request
Jun 19, 2015
Do not monkey patch the app's YAML
|
Thanks! |
|
I guess #2397 got lost? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeYAML provides a way to avoid monkey-patching the
YAMLobject. Thisshould be used to avoid overwriting the application's
YAML.This was causing problems with our application, which uses Psych's
YAML.safe_loadmethod in ways that are incompatible with SafeYAML's implementation. It's important to note thatYAML.safe_loadhas existed in Ruby's stdlib since 2.1.0.